Merged
Conversation
* Fix new link_sent page back link Needed to use idv_doc_auth_step_url instead of idv_doc_auth_url [skip changelog] --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
* LG-9440 Add headers & data on verify_info w/ tests * LG-9440 Remove extra line * changelog: Upcoming Features, In-person proofing, Apply all DAV functional and design changes to the controller-based version of the verofy info page * LG-9440 fix lint issues * LG-9440 Move prepare step before location, flow changed * LG-9440 Moved method out of verify_info_concern bc it is not shared * LG-9440 Style updates * LG-9440 Update line density above Current resident * LG-9440 Modify and move eval for cap second id * LG-9440 Add logic to redirect to address * LG-9440 Update test spec eval Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov> * LG-9440 Delete unnecessary test * refactor skipping verify_info redirect Co-authored-by: gina-yamada <gina.yamada@gsa.gov> * LG-9440 Remove extra space * LG-9440 linter fixes * LG-9440 Move test to verify_info_spec * LG-9440 linter fix * LG-9440 Deleted unused method * LG-9440 refactor to remove extr FSM mp --------- Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
* Replace Sprockets with Propshaft changelog: Internal, Build Tooling, Update asset pipeline to replace Sprockets with Propshaft * Update script_helper_spec.rb * Handle missing asset * Improve RackAttack spec to avoid requiring file present * Use static asset host Propshaft can't handle proc value. Hopefully the "request is nil" issue no longer happens after transitioning * Exclude Propshaft manifest
* Refactor interface to add shared "config" (to not have unused argument **extra) changelog: Internal, Reporting, Add data-pull subtask to streamline IG reports
This commit adds a test that tests that a user who went through fraud review and either expired or was explicitly reject cannot enter the IdV flow. The tests in the codebase prior to this change cover the fraud pending state. The fraud rejection state is slightly different and we track differently. [skip changelog]
* Try absolute path for Propshaft assets [skip changelog] * Missed a couple "url"
We have a bunch of disparate logic around checking whether a user has or should be deactivate for fraud. This commit introduces the `FraudReviewCheck` class. The intention of this class is to provide a place to consolidate logic to determine if a user has a pending fraud review check. I am planning to follow this up with logic that determines if a user should receive a timestamp update for a pending fraud review check. [skip changelog]
changelog: Internal, Build Tooling, Update asset pipeline to replace Sprockets with Propshaft
[skip changelog] * Check telephony failure_reason in UploadStep before redirecting to LinkSent * RedoDocumentCaptureAction redirects to document capture if skipping upload --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
changelog: Internal, Build Tooling, Update asset pipeline to replace Sprockets with Propshaft
… user to phone page (#8368) * remove account setup check changelog: Bug fix, phone setup, 'use another phone number' goes to phone setup * add feature test for use another phone number * add account setup check * change path to different controller * Empty commit * Empty commit * experiment: path change * Revert "remove account setup check" This reverts commit 5bb649e. * remove duplicate method * fix: add phone path * fix tests for otp show * add concern and before action
* Improve LinkSent before action If flow_path is standard, redirect to DocumentCaptureStep. If flow_path is not set, redirect to FSM (UploadStep). [skip changelog]
* Revert "Fix handling for missing SP logo (#8409)" This reverts commit e3da0a7. * Revert "Try absolute path for Propshaft assets (#8402)" This reverts commit 8a97e26. * Revert "Replace Sprockets with Propshaft (#8387)" This reverts commit c8d8a38. * Keep spec improvements from e3da0a7 * Keep spec improvements from c8d8a38 * Keep webpack digest suffix from c8d8a38
* LG-7521 Edit css of last child in list * changelog: User-Facing Improvements, In-person proofing, Remove double line on Post Office search results view * LG-7521 Fix lint issue * LG-7521: Nest sass syntax Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…gible (#8408) A previous commit (#8397) introduced the `FraudReviewChecker` which includes a method for checking that a user is eligible for fraud review. It did not end up getting used in the rake task where that check is performed. This commit does that and removes the old method from the user model. [skip changelog]
aduth
approved these changes
May 17, 2023
Contributor
Author
Thanks! Yanked 'em |
We should not be activating profiles that have a deactivation reason. The logic for that looks like it got mixed up when we were doing the fraud review work. Specifically the code to check for a deactivation reason does not actually look at the deactivation reason column anymore. This commit addresses the above. [skip changelog] (cherry picked from commit df5a905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features