Conversation
changelog: Internal, Build Tooling, Update asset pipeline to replace Sprockets with Propshaft
jmhooper
approved these changes
May 16, 2023
| service_provider_request: ServiceProviderRequestProxy.new, | ||
| ) | ||
|
|
||
| expect(subject.sp_logo_url).is_a? String |
Contributor
There was a problem hiding this comment.
oops that was not an assertion! glad we caught
Contributor
Author
There was a problem hiding this comment.
Yeah 😬 I also did a regex search expect\(.+?\)\.is_a to find any others, looks like this is the only one.
aduth
added a commit
that referenced
this pull request
May 17, 2023
* Revert "Fix handling for missing SP logo (#8409)" This reverts commit e3da0a7. * Revert "Try absolute path for Propshaft assets (#8402)" This reverts commit 8a97e26. * Revert "Replace Sprockets with Propshaft (#8387)" This reverts commit c8d8a38. * Keep spec improvements from e3da0a7 * Keep spec improvements from c8d8a38 * Keep webpack digest suffix from c8d8a38
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an error which can happen if the logo associated with a service provider cannot be resolved.
Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1684269870234819
The problems are:
image_path. The logic ofimage_pathalways returns a string, even if not found (source), but we returnednilinstead in the error handler..is_a?change)_nav_branded.html.erbspecs, which is where the error was happening