Skip to content

LG-7521 Remove Double Rule#8413

Merged
gina-yamada merged 5 commits intomainfrom
gina/LG-7521-remove-double-rule
May 17, 2023
Merged

LG-7521 Remove Double Rule#8413
gina-yamada merged 5 commits intomainfrom
gina/LG-7521-remove-double-rule

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented May 17, 2023

🎫 Ticket

LG-7521 Adjust component to avoid appearance of a double rule

🛠 Summary of changes

Remove double line below Post Office search results (/verify/document_capture#location on Find a participating Post Office)

📜 Testing Plan

  1. Create an account
  2. Attempt to verify your identity via /verify
  3. Upload front/back of ID to fail identity verification
  4. Click Try in person and Continue to get to Find a participating Post Office (via /verify/document_capture#location)
  5. Enter text in the input field and click Search
  6. Scroll to the bottom of the page. You should not see a double line below the search results
  7. Poke through app, nothing else should be effected.

👀 Screenshots

Before: Screenshot 2023-05-17 at 8 36 48 AM
After: Screenshot 2023-05-17 at 8 35 19 AM

@gina-yamada gina-yamada requested a review from kellular May 17, 2023 14:44
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment about Sass syntax to consider, but LGTM otherwise 👍

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Copy link
Contributor

@JackRyan1989 JackRyan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gina-yamada gina-yamada changed the title Gina/lg 7521 remove double rule LG-7521 Remove Double Rule May 17, 2023
Copy link

@kellular kellular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Gina!

@gina-yamada gina-yamada merged commit 3f68f79 into main May 17, 2023
@gina-yamada gina-yamada deleted the gina/LG-7521-remove-double-rule branch May 17, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants