Jmax/lg 9107 remove fsm document capture hybrid flow step#8292
Jmax/lg 9107 remove fsm document capture hybrid flow step#8292
Conversation
This was used by the async code, which is unused.
Async document capture has not been used.
Replaced by hybrid_mobile/hybrid_mobile_spec.rb
jskinne3
left a comment
jskinne3
left a comment
There was a problem hiding this comment.
I don't know much about the FSM (RIP) but from the little I do, this all appears to make sense. I left one minor question.
| status_endpoint: FeatureManagement.document_capture_async_uploads_enabled? ? | ||
| send(@step_url, step: :verify_document_status) : | ||
| nil, | ||
| status_endpoint: nil, |
There was a problem hiding this comment.
Can this be removed entirely ?
There was a problem hiding this comment.
I'm also generally confused if we're intending to maintain the async implementation, because it seems like it's partly lingering, but this would remove some parts of the implementation toward a less-complete state.
There was a problem hiding this comment.
We put in a separate ticket LG-9611 for removing the async implementation, because there was so much of it.
| end | ||
|
|
||
| def self.analytics_submitted_event | ||
| :idv_doc_auth_verify_document_status_submitted |
There was a problem hiding this comment.
I don't see AnalyticsEvents#idv_doc_auth_verify_document_status_submitted called anywhere else. Should it be? And if not, should the method be removed?
There was a problem hiding this comment.
Removed this, thanks.
| private | ||
|
|
||
| def process_async_state(current_async_state) | ||
| form = ApiDocumentVerificationStatusForm.new( |
There was a problem hiding this comment.
This form implementation appears to be unused now. Should it be removed?
There was a problem hiding this comment.
Added this form name to LG-9611 to make sure we don't leave it behind.
| status_endpoint: FeatureManagement.document_capture_async_uploads_enabled? ? | ||
| send(@step_url, step: :verify_document_status) : | ||
| nil, | ||
| status_endpoint: nil, |
There was a problem hiding this comment.
I'm also generally confused if we're intending to maintain the async implementation, because it seems like it's partly lingering, but this would remove some parts of the implementation toward a less-complete state.
…sm-document-capture-hybrid-flow-step
…sm-document-capture-hybrid-flow-step
To be removed in LG-9611
…sm-document-capture-hybrid-flow-step
jmax-gsa
deleted the
jmax/LG-9107-remove-fsm-document-capture-hybrid-flow-step
branch
4 participants
🎫 Ticket
LG-9107
🛠 Summary of changes
Removed hybrid flow document capture from FSM
Release Plan
Deploy Hybrid Mobile code #8243
Merge and deploy PR to remove 404 action
Test 50/50 state in int
Turn on feature flag doc_auth_hybrid_mobile_controllers_enabled in production
at this point, we're ready to merge and deploy this pr
Merge and deploy delete PR for now-unused FSM capture doc flow.
We put in a separate ticket LG-9611 for removing the async implementation, because there was so much of it.