Skip to content

Use Redis 7 EXPIRETIME command for calculating rate limit state#7776

Merged
mitchellhenke merged 6 commits intomainfrom
mitchellhenke/redis-7-expiretime
May 4, 2023
Merged

Use Redis 7 EXPIRETIME command for calculating rate limit state#7776
mitchellhenke merged 6 commits intomainfrom
mitchellhenke/redis-7-expiretime

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

Last week's infrastructure deploy included the upgrade from Redis 6 to Redis 7 (https://github.com/18F/identity-devops/pull/5751). With the upgrade complete and settled in, we can make use of the new Redis 7 command that should be a bit more stable for our usage.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke
Copy link
Contributor Author

Looks like https://github.com/resque/redis-namespace does not support EXPIRETIME yet 😞

@mitchellhenke
Copy link
Contributor Author

Opened resque/redis-namespace#221 to hopefully add it

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch from 3ad6f72 to 80a471e Compare February 27, 2023 17:27
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch from 80a471e to c56f416 Compare March 11, 2023 22:00
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch 3 times, most recently from a3f03ba to 6ff0e11 Compare March 15, 2023 15:44
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch 7 times, most recently from f60dd2f to a61407e Compare March 24, 2023 16:59
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch from a61407e to 31c4e91 Compare April 12, 2023 16:47
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch from 31c4e91 to 5ac55c0 Compare May 3, 2023 17:35
Mitchell Henke added 6 commits May 4, 2023 10:09
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/redis-7-expiretime branch from 5ac55c0 to 3acf991 Compare May 4, 2023 15:10
@mitchellhenke mitchellhenke merged commit 10bdf91 into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants