Upgrade redis-session-store to improve performance and security#8253
Merged
mitchellhenke merged 11 commits intomainfrom Apr 26, 2023
Merged
Upgrade redis-session-store to improve performance and security#8253mitchellhenke merged 11 commits intomainfrom
mitchellhenke merged 11 commits intomainfrom
Conversation
Comment on lines
15
to
29
Contributor
There was a problem hiding this comment.
since the gem is basically ours now, WDYT of exposing a ttl method on it instead of having to instance_eval?
Contributor
Author
There was a problem hiding this comment.
I was hoping to some day get to switching this to use expiretime (after #7776 😬) which has some limitations on Redis version, so my soft preference is to keep IDP-specific things here to avoid complexity in the gem.
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
6 times, most recently
from
8c6bb26 to
8f903b1
Compare
added 7 commits
April 26, 2023 10:47
changelog: Internal, Session Management, Upgrade redis-session-store to improve performance and security
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
from
e5d1025 to
7f25be6
Compare
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
from
bc27fc8 to
7cbb7ef
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
from
5c991fb to
f560ac9
Compare
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
from
f560ac9 to
62ff40c
Compare
mitchellhenke
force-pushed
the
mitchellhenke/redis-session-store-exists
branch
from
a787303 to
62ff40c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR pulls in the changes from 18F/redis-session-store#9 and 18F/redis-session-store#10. The description in the first PR contains a fuller list of the changes as well as a couple small benchmarks against the IDP
The significant change in this upgrade is the migration of session identifiers to more fully address the vulnerability described in GHSA-hrqr-hxpp-chr3. We mitigate the vulnerability in other ways currently, but this should remediate. Briefly, the idea is to use the hashed public_id (referred to as private_id) as the lookup key for the session in Redis and return the public_id for storage on client-side. The migration plan is described in this roll plan.
The session identifiers are used outside of the request cycle for the
OutOfBandSessionAccessorto serve OIDC/SAML requests, so there is accommodation of the identifier migration there as well.This is still a draft PR and should not be merged.