Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/remove-redis-namespace
branch
from
655a721 to
ae3bcb1
Compare
mitchellhenke
force-pushed
the
mitchellhenke/remove-redis-namespace
branch
2 times, most recently
from
9185e32 to
b96b9d7
Compare
zachmargolis
approved these changes
Mar 10, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
This looks deceptively straightforward. Either we missed something, or our app is very well-factored and I choose to believe the latter.
mitchellhenke
force-pushed
the
mitchellhenke/remove-redis-namespace
branch
from
b96b9d7 to
d316fd1
Compare
zachmargolis
approved these changes
Mar 13, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM
I ran this to help me find more places to spot check for redis commands we might need to prefix:
git grep -l -i redis -- app lib
Looks like we already got these two as part of the previous REDIS_POOL PR so I think we're good now:
https://github.com/18F/identity-idp/blob/a561529a6b722d7c2faa2196c1293601333e68b6/app/services/service_provider_request_proxy.rb#L6
https://github.com/18F/identity-idp/blob/a561529a6b722d7c2faa2196c1293601333e68b6/app/services/encrypted_redis_struct_storage.rb#L64
mitchellhenke
force-pushed
the
mitchellhenke/remove-redis-namespace
branch
from
c57e1cf to
4a85c89
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 14, 2023
changelog: Internal, Redis, Remove redis-namespace gem
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We've been blocked on merging #7776 because of our usage of
redis-namespace. We could consider forking and using the patch mentioned the pull request, but the functionality of the gem is straightforward enough to replace and gives us the opportunity to drop a dependency.