Merged
Conversation
* Push for CI run [skip changelog] * Checkpoint; about to remove ddp mock proofer * More code removed. * Resolve style issues * Reformat request made context * Get back to a passing state * Replace inconsistent method * Remove inconsistent return * Make AAMVA response consistent * Use subject, described_class, and result consistently * Make spec code more consistent * Restore ruby version * Mark unsupported methods and tests * Mark unsupported tests and methods * Consolidate tests * Improve style * Restore timed_out? for resolution job * Use AAMVA result class * Satisfy resolution proofing job spec for now * Restore passing state * Use resolution result for resolution proofer * Define default values in resolution result constructor * Define shared lexis nexis config class * Replace one more config reference * Remove result assignment that examples override * Align method call with block name * Unify result classes * Rename Result to DdpResult * Improve style * Build result like other proofers * Remove untested methods * Restore result spec tests and failed? result method * Restore mock classes * Add trailing newline * Target RDP proofer in specs --------- Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
…tus (#7743) * handle unexpected responses test for unexpected number of days until expiration * tests for invalid enrollment code & applicant * changelog: Bug Fixes, In-person proofing, Handle unexpected api errors
* changelog: Internal, In-Person Proofing, Remove redundant ArcGIS API call * Update method comment * Update address_search_controller test spec * Clarify code comment * Drop vestigial * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Revert outFields change * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Restore mock clients in verify wait step show spec * [skip changelog]
* TypeScript-ify PhoneInput element * [skip changelog] * Update renamed export member
* changelog: Internal, In-Person Proofing, Remove redundant ArcGIS API call * Update method comment * Update address_search_controller test spec * Clarify code comment * Drop vestigial * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Revert outFields change * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * changelog: Bug Fixes, In-Person Proofing, Restrict ArcGIS address search category * Spread arguments so this works --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
… info controller (#7748) The verify info controller is a replacement for the verify info step. When it was being built we overlooked a feature that allowed users with barcode errors to recapture an image of their document. This commit implements that feature for the verify info controller [skip changelog]
* [skip changelog] Adds ial and all to OIDC JWT response * [skip changelog] Clean up debugging stuffs * changelog: additional clean up additional cleanup
**Why**: So that throttles/short lived things live in the same instance changelog: Internal, Rate limiting, Update redis rate limiting configuration
…#7741) * Throttle#increment! does nothing if already throttled Do not reset the wait time on further attempts if already throttled, add tests * Remove Throttle#throttled_else_increment? method * Users::TwoFactorAuthenticationController - replace throttled_else_increment? * Idv::GpoVerifyController - replace throttled_else_increment? Adjust the spec expected attempts by 1 * Idv::VerifyInfoController - replace throttled_else_increment? And add feature spec to test ssn throttling Check for correct # of attempts text in throttle warning in VerifyInfo feature test Add click_try_again test helper * Idv::Steps::DocAuthBaseStep - remove unused local throttled_else_increment method * Idv::Steps::VerifyBaseStep - replace throttled_else_increment? Adjust specs expected attempts by 1 * RequestPasswordReset - replace throttled_else_increment? Adjust spec expected attempts by 1 * RegisterUserEmailForm - replace throttled_else_increment? Adjust spec expected attempts by 1 * Idv::ApiDocumentVerificationForm - replace throttled_else_increment? * Idv::ApiImageUploadForm - replace throttled_else_increment? * Idv::Steps::SendLinkStep - replace throttled_else_increment? Adjust spec expected attempts by 1 * Users::VerifyPersonalKeyController - replace throttled_else_increment? Adjust spec expected attempts by 1 Increase verify_personal_key_max_attempts test config setting to 2 so that create works * Remove analytics from Idv::SessionErrorsController#throttled Because now spec/features/idv/doc_auth/document_capture_step_spec.rb passes without that * Adjust feature throttling specs expected attempts by 1 Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov> changelog: Internal, refactor, make rate limiting code consistent
changelog: Internal, Reporting, Include deleted users in reports on users created
aduth
requested review from
Jeremy1026,
allthesignals,
jmax-gsa,
jmhooper,
kbighorse,
soniaconnolly,
tomas-nava and
zachmargolis
mitchellhenke
approved these changes
Feb 6, 2023
soniaconnolly
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
ialandaalproperties in user info response value (#7721)Internal