Skip to content

Add ial and aal to OIDC userinfo response#7721

Merged
Jeremy1026 merged 3 commits intomainfrom
jcurcio/lg-8704-add-ial-and-aal-to-userinfo-response
Feb 2, 2023
Merged

Add ial and aal to OIDC userinfo response#7721
Jeremy1026 merged 3 commits intomainfrom
jcurcio/lg-8704-add-ial-and-aal-to-userinfo-response

Conversation

@Jeremy1026
Copy link
Contributor

@Jeremy1026 Jeremy1026 commented Jan 30, 2023

🎫 Ticket

LG-8704

🛠 Summary of changes

Updates OIDC response to include IAL and AAL information returned to the user in the JWT.

Testing Plan

  • Start and visit your local OIDC Sinatra Application
  • Set the AAL level and Level of Service to whatever level you want
  • Log in
  • Look for the new ial and aal parameters in the response

@Jeremy1026 Jeremy1026 marked this pull request as draft January 30, 2023 15:32
@Jeremy1026 Jeremy1026 force-pushed the jcurcio/lg-8704-add-ial-and-aal-to-userinfo-response branch 2 times, most recently from aa07f9b to a62416c Compare January 30, 2023 15:39
Adds ial and all to OIDC JWT response
@Jeremy1026 Jeremy1026 force-pushed the jcurcio/lg-8704-add-ial-and-aal-to-userinfo-response branch from a62416c to 832d0ff Compare January 30, 2023 15:41
Clean up debugging stuffs
@mitchellhenke
Copy link
Contributor

Just want to note I think we will want a changelog entry for this change 🙂

@Jeremy1026
Copy link
Contributor Author

Just want to note I think we will want a changelog entry for this change 🙂

I'll include in the final commit when ready, the changelog step in gitlab and I don't get along. Don't want to get hung up on it while working.

@mitchellhenke
Copy link
Contributor

Just want to note I think we will want a changelog entry for this change 🙂

I'll include in the final commit when ready, the changelog step in gitlab and I don't get along. Don't want to get hung up on it while working.

Ah got it. It only needs to see it once to skip going forward.

@Jeremy1026 Jeremy1026 marked this pull request as ready for review January 31, 2023 14:40
@Jeremy1026 Jeremy1026 merged commit 39d89d9 into main Feb 2, 2023
@Jeremy1026 Jeremy1026 deleted the jcurcio/lg-8704-add-ial-and-aal-to-userinfo-response branch February 2, 2023 18:34
@mitchellhenke
Copy link
Contributor

Want to flag for @aduth (next week's deployer) that the changelog was skipped here, but we'd like to include a changelog in the next release for this since it's a more significant improvement to functionality

@aduth aduth mentioned this pull request Feb 6, 2023
@aduth
Copy link
Contributor

aduth commented Feb 6, 2023

Want to flag for @aduth (next week's deployer) that the changelog was skipped here, but we'd like to include a changelog in the next release for this since it's a more significant improvement to functionality

I came up with this for #7773:

Bug Fixes

  • OpenID Connect: Include ial and aal properties in user info response value (#7721)

@mitchellhenke @Jeremy1026 @nprimak please let me know if I haven't accurately captured the changes.

@mitchellhenke
Copy link
Contributor

@aduth thank you, looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants