Skip to content

Remove Proofing::Result class#7635

Merged
kbighorse merged 50 commits intomainfrom
LG-8257-modify-ddp-proofer-to-not-use-proofing-result
Feb 1, 2023
Merged

Remove Proofing::Result class#7635
kbighorse merged 50 commits intomainfrom
LG-8257-modify-ddp-proofer-to-not-use-proofing-result

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Jan 12, 2023 •
edited by kbighorse
Loading

🎫 Ticket

LG-8257.

This PR:

  • redefines all former references to Proofing::Result to appropriate Result classes
  • redefines Proofing::Result to Proofing::DdpResult
  • moves Proofing::LexisNexis::Ddp::Proofer::Config to its own class Proofing::LexisNexis::Config
  • modifies Result and ResultSpec code to be more consistent
  • and more

@jmax-gsa jmax-gsa force-pushed the LG-8257-modify-ddp-proofer-to-not-use-proofing-result branch from 5a16f19 to 281b1c0 Compare January 12, 2023 19:14
@jmax-gsa jmax-gsa force-pushed the LG-8257-modify-ddp-proofer-to-not-use-proofing-result branch from 884b28a to e2c4db4 Compare January 13, 2023 17:26
@kbighorse
Resolve style issues
c650024
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
13112ee 
…ng-result
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
dced44a 
…ng-result
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
72394c0 
…ng-result
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
a3f92a1 
…ng-result
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
7f77e72 
…ng-result
@kbighorse
Reformat request made context
ba397db
@kbighorse
Get back to a passing state
d738cf8
@kbighorse
Replace inconsistent method
bc50bfb
@kbighorse
Remove inconsistent return
4f6f7eb
@kbighorse
Make AAMVA response consistent
43114dd
@kbighorse
Use subject, described_class, and result consistently
1388fc1
@kbighorse
Make spec code more consistent
ef26fb3
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
434eb62 
…ng-result
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
93fb324 
…ng-result
@kbighorse
Restore ruby version
6ad40e4
@kbighorse
Mark unsupported methods and tests
885e305
@kbighorse
Mark unsupported tests and methods
91a0b74
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
7c5f895 
…ng-result
@kbighorse
Consolidate tests
7b52dad
@kbighorse
Improve style
a44e1e7
@kbighorse
Restore timed_out? for resolution job
31010f9
@kbighorse
Use AAMVA result class
5a9ec15
@kbighorse
Merge branch 'main' into LG-8257-modify-ddp-proofer-to-not-use-proofi…
7599f1f 
…ng-result
@kbighorse kbighorse changed the title Push for CI run Remove Proofing::Result class Jan 26, 2023
@kbighorse kbighorse marked this pull request as ready for review January 27, 2023 01:20
@kbighorse kbighorse requested a review from jmhooper January 27, 2023 01:21
@kbighorse
Copy link
Contributor

kbighorse commented Jan 27, 2023

This arguably satisfies the feature requirement, but still needs polish and cleanup, in progress.

theabrad
theabrad approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbighorse kbighorse merged commit 6c05768 into main Feb 1, 2023
@kbighorse kbighorse deleted the LG-8257-modify-ddp-proofer-to-not-use-proofing-result branch February 1, 2023 18:21
@kbighorse kbighorse mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theabrad theabrad theabrad approved these changes

@jmhooper jmhooper Awaiting requested review from jmhooper

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmax-gsa @kbighorse @theabrad