Conversation
… info controller The verify info controller is a replacement for the verify info step. When it was being built we overlooked a feature that allowed users with barcode errors to recapture an image of their document. This commit implements that feature for the verify info controller [skip changelog]
aduth
approved these changes
Feb 2, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I tried testing locally but I wasn't able to get past the document capture step with my test document. Unsure if that's something with my test file / local environment, or a real issue? In any case, the code itself looks good.
Test file:
document:
type: license
first_name: Susan
last_name: Smith
middle_name: Q
address1: 1 Microsoft Way
address2: Apt 3
city: Bayside
state: NY
zipcode: "11364"
dob: 10/06/1938
phone: +1 314-555-1212
failed_alerts:
- name: 2D Barcode Read
result: Attention
soniaconnolly
approved these changes
Feb 2, 2023
| 'doc_auth.headings.capture_scan_warning_html', | ||
| link: render( | ||
| FormLinkComponent.new( | ||
| href: idv_doc_auth_step_path(step: :redo_document_capture), |
Contributor
There was a problem hiding this comment.
Eventually, redo_document_capture will need to be its own controller and this link will need to change. Looks good for now.
Contributor
Author
There was a problem hiding this comment.
Agreed, we may want to throw together a story for that 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify info controller is a replacement for the verify info step. When it was being built we overlooked a feature that allowed users with barcode errors to recapture an image of their document.
This commit implements that feature for the verify info controller