Add "human detection" to voice OTP phone call#768
Closed
zachmargolis wants to merge 1 commit intomasterfrom
Closed
Add "human detection" to voice OTP phone call#768zachmargolis wants to merge 1 commit intomasterfrom
zachmargolis wants to merge 1 commit intomasterfrom
Conversation
fa26ea0 to
b554f76
Compare
**Why**: So we don't read our OTPs into people's voicemails **How**: Replace intial message that reads the code with one that prompts users to press 1 to hear the code
Contributor
|
I'm testing this right now, and the voice message keeps playing in a loop: This repeats seemingly ad infinitum. Is this expected? |
Contributor
Author
|
@monfresh sort of expected? Unfortunately the Twimlet code for menus includes a We'll have to sort out the infinite looping with #761 when we can self-host the TwiML and have more control over menu behavior. Based on some discussion with @usdsclarax in https://github.com/18F/identity-private/issues/604, I'm going to close this issue since our current thinking is we don't need/want human detection. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
So we don't read our OTPs into people's voicemails
How:
Replace intial message that reads the code with one that
prompts users to press 1 to hear the code
Expands on #767 to add human detection