Skip to content

LG-748 Create events for webauthn key management#2635

Merged
monfresh merged 2 commits intomasterfrom
mb-lg-748
Nov 2, 2018
Merged

LG-748 Create events for webauthn key management#2635
monfresh merged 2 commits intomasterfrom
mb-lg-748

Conversation

@monfresh
Copy link
Contributor

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • The changes are compatible with data that was encrypted with the old code.

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • Tests added for this feature/bug

  • Prefer feature/integration specs over controller specs

  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@monfresh monfresh changed the title Hi! Before submitting your PR for review, and/or before merging it, please go through the checklists below. These represent the more critical elements of our code quality guidelines. The rest of the list can be found in [CONTRIBUTING.md] LG-748 Create events for webauthn key management Oct 30, 2018
@monfresh monfresh requested a review from stevegsa October 31, 2018 00:06
@monfresh
Copy link
Contributor Author

This branch is based on #768, hence the 2 commits.

Copy link
Contributor

@jgsmith-usds jgsmith-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question about the tests, this looks good to me.

jgsmith-usds
jgsmith-usds previously approved these changes Nov 1, 2018
**Why**: We want the user to see in their history when hardware security
keys are added and removed.

Also, I updated the analytics attributes to show the user's current
count for each MFA type so we can see which MFA configurations they
ended up with.
@monfresh monfresh merged commit 06ee4f3 into master Nov 2, 2018
@monfresh monfresh deleted the mb-lg-748 branch November 2, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants