Implement "press 1 to repeat" voice OTP behavior via twimlets#767
Implement "press 1 to repeat" voice OTP behavior via twimlets#767zachmargolis merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
is this the max? if so, maybe assign to a var to make test clearer? If not, why pick 4?
There was a problem hiding this comment.
Yeah it's the max, but I'll turn it into a while to make it clearar
There was a problem hiding this comment.
this line is kinda hard to read -- can we break it up somehow?
There was a problem hiding this comment.
I'll split it into a few lines
|
@jessieay at the end of the day, this is building and serving TwiML for us, so I don't really mind. I think ideally we should move towards serving our own TwiML as it gives us more control. However while we're blocked on SSL issues, this gives us menu functionality in the meantime. ¯\_(ツ)_/¯ |
app/jobs/voice_otp_sender_job.rb
Outdated
There was a problem hiding this comment.
if I inline the repeat = message_repeat(code) part to shorten the method and get under the line length limit, reek gets mad about repeat statements, this seemed like a decent compromise to me
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
LGTM! Sounds like this code may go away soon anyway, so inline rubocop comments here don't bother me too much.
zachmargolis
force-pushed
the
margolis-twimlet-menu
branch
from
0119346 to
e9ae03b
Compare
**Why**: Because this is easier to implement than having Twilio call back in to us for the time being
3 participants
Why:
Because this is easier to implement than having Twilio
call back in to us for the time being
This is an alternative to #761