Skip to content

Add "human detection" to voice OTP phone call #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zachmargolis wants to merge 1 commit into from
Closed

Add "human detection" to voice OTP phone call #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/jobs/voice_otp_sender_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,24 @@ def twimlet_url(code) # rubocop:disable Metrics/MethodLength
repeat = message_repeat(code)

twimlet_menu(
repeat,
message_initial,
1 => twimlet_menu(
repeat,
1 => twimlet_menu(
repeat,
1 => twimlet_menu(repeat, 1 => twimlet_message(message_final(code)))
1 => twimlet_menu(
repeat,
1 => twimlet_menu(repeat, 1 => twimlet_message(message_final(code)))
)
)
)
)
end

def message_initial
I18n.t('jobs.voice_otp_sender_job.message_initial')
end

def message_repeat(code)
I18n.t('jobs.voice_otp_sender_job.message_repeat', code: code)
end
Expand Down
10 changes: 6 additions & 4 deletions config/locales/jobs/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ en:

If you did not request this change, please contact %{app} at %{support_url}
voice_otp_sender_job:
message_initial: >
Hello! Press 1 to hear your login.gov one time passcode.
message_repeat: >
Hello! Your login.gov one time passcode is, %{code},
again, your passcode is, %{code}. Press 1 to repeat your code.
Your login.gov one time passcode is, %{code}, again, your passcode is,
%{code}. Press 1 to repeat your passcode.
message_final: >
Hello! Your login.gov one time passcode is, %{code},
again, your passcode is, %{code}, goodbye!
Your login.gov one time passcode is, %{code}, again, your passcode is,
%{code}, goodbye!
17 changes: 12 additions & 5 deletions spec/jobs/voice_otp_sender_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,26 @@
expect(call.to).to eq('555-5555')
expect(call.from).to match(/(\+19999999999|\+12222222222)/)

query = extract_query_params(call.url)
expect(query['Message']).to eq(t('jobs.voice_otp_sender_job.message_initial'))

code = '1234'.scan(/\d/).join(', ')
query = Rack::Utils.parse_nested_query(URI(call.url).query)
expect(query['Message']).to eq(t('jobs.voice_otp_sender_job.message_repeat', code: code))
nested_query = extract_query_params(query['Options']['1'])
expect(nested_query['Message']).
to eq(t('jobs.voice_otp_sender_job.message_repeat', code: code))

nested_query = query
while nested_query['Options']
nested_url = URI(nested_query['Options']['1'])
nested_query = Rack::Utils.parse_nested_query(nested_url.query)
nested_query = extract_query_params(nested_query['Options']['1'])
end

expect(nested_query['Message']['0']).
to eq(t('jobs.voice_otp_sender_job.message_final', code: code))
end

def extract_query_params(url)
Rack::Utils.parse_nested_query(URI(url).query)
end

it 'does not send if the OTP code is expired' do
reset_job_queues
TwilioService.telephony_service = FakeVoiceCall
Expand Down