Merged
Conversation
* change the doc_auth sms to new text * add app_name to beginning of sms message * add user's service provider to the sms * add service_provider to send_doc_auth_link test * put doc auth link back to the front of the sms * add changelog changelog: Improvements, Hybrid Flow, Change SMS of the Hybrid Flow * fix test helper for mobile to get correct link * clean up obtaining service provider in send link step * change variable to sp_or_app_name for more clarity * fix test
* added elapsed_time to analytics irs_attempts_api_events changelog: Internal, Attempts API, logging and monitoring * updated relevant spec files to reflect changes * implemented changes reflecting Matt's feedback.
[skip changelog]
* Render ValidatedFieldComponent as aria-invalid when errors exist changelog: Improvements, Accessibility, Mark fields as invalid when shown with initial errors * Avoid updating DOM on non-changing validity state
* Rearrange changelog contributing guidance to optimize deeplinking changelog: Open Source, Update Contributing guidance for commit changelogs * Rename "Improvements" changelog category * Add changelog (correctly, this time) changelog: Internal, Open Source, Update Contributing guidance for commit changelogs ... the irony of failing to add a valid changelog in a pull request about improving the clarity of our changelog guidance is not lost on me 🤦♂️
changelog: Internal, Open Source, Colocate GitHub issue templates
* Improve reliability of flakey countdown spec changelog: Internal, Automated Testing, Improve reliability of automated tests * Remove seconds normalization #7512 (comment)
* LG-7483: Remove feature flag select_multiple_mfa_options changelog: Bug Fixes, Account Management, Fix missing links to delete MFA methods when phone method is present * Fix specs which assumed second MFA disabled
changelog: User-Facing Improvements, In-person proofing, Update PO Search About text to reflect additional POs coming available soon and CTA Prompt Detail to include comma before D.C. (all languages)
changelog: Internal, Automated Tests, Improve JavaScript tests simulating network requests
* only ForceAuthn if not at final post endpoint * changelog: Bug Fixes, SAML Auth, Update ForceAuthn enforcement * Fixing before_action syntax per rubocop, commenting out spec temporarily
…7486) * Improvements, Voice messaging, Notify voice OTP users how long and what type of code to expect (LG-8089) * update voice * translation update * add check to otp_sender * changelog: Improvements, Voice messaging, Notify voice OTP users how long and what type of code to expect * fix spec
* LG-8388: Confirm ThreatMetrix doesn't block IPP Spec to confirm that IPP is not blocked by a ThreatMetrix result of 'Reject' [skip changelog] * ensure the threatmetrix profiling is enabled * lints * Update spec/features/idv/in_person_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Switching newer Acuant SDK to be the default version -- What The introduction of the AB Testing framework for upgrading the Acuant SDK assumes that the "newer" version is the one being tested, and that the older is the "default". This change updates the step doc capture step to assume that version 11.7.1 should be used in all cases when the ab test is switched off. changelog: Internal, Upgrades, Acuant SDK Upgrade * Specifying acuant versions in configs and updating names Specifically, we are switching from use_newer_sdk to use_alternate_sdk changelog: Internal, Upgrades, Acuant SDK Upgrade * Acuant context should use config's acuant version by default changelog: Internal, Upgrades, Acuant SDK Upgrade * Fixing lints [skip changelog] * Revert "Acuant context should use config's acuant version by default" This reverts commit b420998. [skip changelog] * Removing redundant condition (via @aduth) [skip changelog]
* Abstract logging decision into method * [skip changelog] * lintfix * Test logic in should_log? method * lintfix
* Add filename fingerprint to JavaScript locale data script changelog: Internal, Build Tooling, Invalidate cache for content-only revisions to JavaScript bundles * Update specs
Update OTP language changelog: Improvements, Multi-Factor Authentication, Update OTP language
* Move timeout calculation to helper * Fix calculation of attempted_at and expires_at * changelog: Bug Fixes, DocAuth, Modify retry timer to decrease * Remove instance variable from helper * Revert helper * Indent Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
aduth
requested review from
allthesignals,
eric-gade,
jc-gsa,
julialeague,
kbighorse,
mitchellhenke,
orenyk,
solipet and
theabrad
eric-gade
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features