Conversation
changelog: Improvements, Hybrid Flow, Change SMS of the Hybrid Flow
aduth
approved these changes
Dec 16, 2022
| end | ||
|
|
||
| def sp_name | ||
| service_provider ? service_provider&.friendly_name : APP_NAME |
Contributor
There was a problem hiding this comment.
We should be able to access current_sp here (source), as an alternative to implementing the other new helper method.
Suggested change
| service_provider ? service_provider&.friendly_name : APP_NAME | |
| current_sp&.friendly_name || APP_NAME |
config/locales/telephony/en.yml
Outdated
| doc_auth_link: "%{link} You've requested to verify your identity on a mobile | ||
| phone. Please take a photo of your state issued ID." | ||
| doc_auth_link: |- | ||
| %{app_name}: %{link} You're verifying your identity to access %{service_provider}. Take a photo of your ID to continue. |
Contributor
There was a problem hiding this comment.
I've seen a few other takes on naming the interpolated value to clarify that APP_NAME is possibly inserted, like sp_or_app_name or service_provider_or_app_name. Do you think it'd be worth doing something similar here?
Contributor
Author
There was a problem hiding this comment.
Yep. Good suggestion!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updated Hybrid Handoff SMS to new text which includes which Service Provider the user is verifying from.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
New SMS when verifying from Login.gov
New SMS when verifying from a Service Provider