Improve reliability of flakey countdown spec#7512
Merged
Conversation
changelog: Internal, Automated Testing, Improve reliability of automated tests
mitchellhenke
approved these changes
Dec 19, 2022
Contributor
Author
I suppose an alternative for many of these could have been to stub out all of the relevant values (config and locale string data), which may have made the spec stay a little easier to read. Not stressing it too much, but happy to revisit if there's any strong reactions to it. |
aduth
commented
Dec 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Rewrites parts of a sign-in spec to improve reliability. This had previously been attempted for improvement in #7466, but build failures still occur (example).
This rewrite also has a few improvements:
datetime/en.ymlstring dataPasses regardless of minutes being traversed(Edit: Removed in 6e5221b, see Improve reliability of flakey countdown spec #7512 (comment))session_timeout_in_minutes📜 Testing Plan
rspec spec/features/users/sign_in_spec.rb:269