Skip to content

Improve reliability of flakey countdown spec#7512

Merged
aduth merged 2 commits intomainfrom
aduth-countdown-feature-spec
Dec 19, 2022
Merged

Improve reliability of flakey countdown spec#7512
aduth merged 2 commits intomainfrom
aduth-countdown-feature-spec

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 19, 2022

🛠 Summary of changes

Rewrites parts of a sign-in spec to improve reliability. This had previously been attempted for improvement in #7466, but build failures still occur (example).

This rewrite also has a few improvements:

📜 Testing Plan

rspec spec/features/users/sign_in_spec.rb:269

changelog: Internal, Automated Testing, Improve reliability of automated tests
@aduth
Copy link
Contributor Author

aduth commented Dec 19, 2022

This rewrite also has a few improvements:

I suppose an alternative for many of these could have been to stub out all of the relevant values (config and locale string data), which may have made the spec stay a little easier to read. Not stressing it too much, but happy to revisit if there's any strong reactions to it.

@aduth aduth merged commit 28ac3ed into main Dec 19, 2022
@aduth aduth deleted the aduth-countdown-feature-spec branch December 19, 2022 16:21
@aduth aduth mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants