LG-7483: Remove feature flag select_multiple_mfa_options#7505
Conversation
There was a problem hiding this comment.
This code is unreachable, since PhoneSelectionPresenter overrides the info method and therefore setup_info would not be called for those methods. The code here is incorrect anyways, since it's showing the Kantara messaging based on select_multiple_mfa_options (should only be shown with kantara_2fa_phone_restricted).
jmdembe
left a comment
There was a problem hiding this comment.
This makes sense. LGTM 👍🏾
There was a problem hiding this comment.
I'm a little confused at needing to remove some of these SAML-specific handling, though as I understand why they were introduced in #6894 to trigger the post-auth redirect that's typically handled in JavaScript, I feel like it would be unexpected that a SAML auth would be "complete" at this point. In main, the URL here is the same as what's being asserted below (UriService.add_params(@saml_authn_request, locale: :es)), which feels very unexpected. My guess is that based on the timing of the merge of #6894 being after multiple MFA setup was already live in most environments, this was buggy in situations where the config was turned off (as it had been in test environments), and that the changes here are the correct, expected behavior.
changelog: Bug Fixes, Account Management, Fix missing links to delete MFA methods when phone method is present
964f56e to
a1ba73b
Compare
🎫 Ticket
LG-7483
🛠 Summary of changes
Removes the
select_multiple_mfa_optionsfeature flag, which is now live in all environments.Also fixes an issue where MFA "Delete" links would not be shown on the account dashboard in some circumstances, since that was intended to apply only for Kantara restrictions (not live in production), but instead had been keying off the
select_multiple_mfa_optionsfeature (live in production).📜 Testing Plan
The second test procedure requires overrides in local development
config/application.yml(until LG-7586):