LG-8156: Updating to Acuant SDK 11.7.1#7378
Merged
Conversation
added 2 commits
November 21, 2022 14:59
changelog: Internal, Updates, Updating to Acuant SDK 11.7.1
aduth
approved these changes
Nov 21, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Tested locally on Android, LGTM 👍
| }; | ||
|
|
||
| function AcuantContextProvider({ | ||
| sdkSrc = '/acuant/11.7.0/AcuantJavascriptWebSdk.min.js', |
Contributor
There was a problem hiding this comment.
We never followed-up with a pull request to remove 11.5.0 after the last upgrade. Can we plan to preemptively get the pull request ready to remove this old version (along with 11.5.0) so it doesn't fall off our radar?
Contributor
Author
|
Our testing on the new iPhone has worked and this is ready to go. The only stipulation is that we will delay the follow-up PR removing 11.7.0, because there is a new ticket for implementing a/b testing of 11.7.0 vs 11.7.1, which will be the immediate follow up. |
Contributor
Can we at least remove v11.5.0 ? |
Contributor
Author
|
changelog: Internal,SDK Upgrade, removing unused Acuant SDK 11.5.0 files
aduth
approved these changes
Nov 22, 2022
spec/javascripts/packages/document-capture/components/acuant-sdk-spec.js
Outdated
Show resolved
Hide resolved
…dk-spec.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
-- What In the 11.7.0 update, the Acuant SDK was available in the global scope, but not on the window object -- and we tested for this specific case since it broke many previous assumptions. With the 11.7.1 this inconsistency has been fixed (and is even noted in the release notes here: https://github.com/Acuant/JavascriptWebSDKV11/releases/tag/11.7.1) changelog: Internal, SDK Upgrade, Upgrading Acuant SDK to 11.7.1
Merged
mitchellhenke
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Updating to Acuant SDK 11.7.1 * Add changelog changelog: Internal, Updates, Updating to Acuant SDK 11.7.1 * Removing unused 11.5.0 Acuant SDK files changelog: Internal,SDK Upgrade, removing unused Acuant SDK 11.5.0 files * Update spec/javascripts/packages/document-capture/components/acuant-sdk-spec.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Fixing test assumption about window scope -- What In the 11.7.0 update, the Acuant SDK was available in the global scope, but not on the window object -- and we tested for this specific case since it broke many previous assumptions. With the 11.7.1 this inconsistency has been fixed (and is even noted in the release notes here: https://github.com/Acuant/JavascriptWebSDKV11/releases/tag/11.7.1) changelog: Internal, SDK Upgrade, Upgrading Acuant SDK to 11.7.1 Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This was referenced Nov 29, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8156
🛠 Summary of changes
Adding Acuant SDK Application bundles for 11.7.1 and updating application code references to point to this newer version.
📜 Testing Plan
(We are expecially interested in the newer iPhone 14 (pro max), which has a wider focus than other devices and cannot capture documents)