Merged
Conversation
mdiarra3
force-pushed
the
stages/rc-2022-11-28
branch
2 times, most recently
from
0b98517 to
9657a83
Compare
… Page (#7284) * Implement try again logic for Inherited Proofing changelog: Upcoming Features, Inherited Proofing, LG-7450 Implement "Try Again" Button Functionality on the First Error Page Refactor code to enqueue user PII job to mixin - To keep things DRY as this will be used in the verify_wait step when the user clicks the "Retry" button on the IP Warning UI. Refactor to use UserPiiJobInitiator mixin Add translations for request/response errors - Related to inherited proofing service provider requests and responses; this, so that we can 1) record the error and 2) display something to the user. Errors displayed to the user are "safe" errors, revealing no information that could be used by those having ill intentions. Refactor VA form and service classes - To handle network errors encountered during the request to the service provider and decrypting response data returned from the service provider request. Allow va mock proofer to return meaningful error - So that we can identify the error in the va Form class as such and notify our Flow that an error has indeed occured. The error added to the mock proofer is a network-related error, not a va api related (returned in a response) error. Enable flow step to hook into "try again" logic - Which exists in the base class. Enable flow step to hook into "try again" logic DRY VerifyBaseStep for Inherited Proofing usage Set up throttling for Inherited Proofing Change the path the "Try again" button uses - To point to the :verify_wait flow step so the user can try again. Automated tests Refactor inherited_proofing_cancel_spec.rb - To use InheritedProofingWithServiceProviderHelper. * Address PR feedback - Remove unnecessary call to super in FormBase class. - Remove #extra method in FormBase. - Rename add_service_error_if method to add_service_error and add conditional callback if: :service_error? - Fix spec to check actual :service_error hasn key value instead of converting the hash to a string and checking that. * Add missing failure method to BaseFlow - This seemed a better option than making BaseFlow an abstract class raising NoMethodError, since it looks like the logic would be the same anyhow. * Create step action to retry user pii retrieval * Address latest PR feedback
* Include OTP adapter when logging the OTP send event changelog: Internal, Logging, Include OTP adapter when logging the OTP send event * Fix typo * Update app/controllers/idv/otp_delivery_method_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * add specs Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Add content_type to DataUrlImage * First pass at wiring doc upload into attempts API changelog: Improvements, IRS Attempts API, Add document escrow fields to IRS attempts API * Additional tests * WIP * Update form test to roundtrip documents Write documents to encrypted storage and read them back * Use front_image & back_image lets for tests * Update ImageUploadsController spec * Test Attempts API includes images on validation failure * Update app/forms/idv/api_image_upload_form.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/encrypted_document_storage/local_storage.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update *_image -> *_image_uuid Clarify that these args hold UUIDs identifying the front/back images * Use let() for regexes in tests avoid polluting global namespace * Add doc escrow parameter descriptions * Minimize unnecessary verbosity * Lint issues * Reduce number of document escrow fields 50% off! * add "filename" to fields try and make it clearer what these things are * Remove empty test whoops * Update app/services/encrypted_document_storage/document_writer.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update spec from `should` to `is_expected.to` Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Base GPO expiration on original request date Rather than basing on the date we FTP the .csv file out, base the expiry on the time of the original request's creation. For LG-8063 changelog: Bug Fixes, GPO, Address issue where expiration date on GPO letters was not printed correctly. * Switch to Time.zone.parse
mdiarra3
force-pushed
the
stages/rc-2022-11-28
branch
from
9657a83 to
d745863
Compare
aduth
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal
Upcoming Features