Skip to content

LG-8156: Updating to Acuant SDK 11.7.1 #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-gade merged 5 commits into from
Nov 23, 2022
Merged

LG-8156: Updating to Acuant SDK 11.7.1 #7378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e323d8
Updating to Acuant SDK 11.7.1
Nov 21, 2022
a47b66c
Add changelog
Nov 21, 2022
ebe4548
Removing unused 11.5.0 Acuant SDK files
Nov 22, 2022
babfd9d
Update spec/javascripts/packages/document-capture/components/acuant-s…
eric-gade Nov 23, 2022
4662727
Fixing test assumption about window scope
Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/packages/document-capture/context/acuant.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ const getActualAcuantCamera = (): AcuantCameraInterface => {
};

function AcuantContextProvider({
sdkSrc = '/acuant/11.7.0/AcuantJavascriptWebSdk.min.js',

@aduth aduth Nov 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never followed-up with a pull request to remove 11.5.0 after the last upgrade. Can we plan to preemptively get the pull request ready to remove this old version (along with 11.5.0) so it doesn't fall off our radar?

cameraSrc = '/acuant/11.7.0/AcuantCamera.min.js',
sdkSrc = '/acuant/11.7.1/AcuantJavascriptWebSdk.min.js',
cameraSrc = '/acuant/11.7.1/AcuantCamera.min.js',
credentials = null,
endpoint = null,
glareThreshold = DEFAULT_ACCEPTABLE_GLARE_SCORE,
Expand Down
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantCamera.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantImageService.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added public/acuant/11.7.1/AcuantImageService.wasm
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantImageWorker.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantInitializerService.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added public/acuant/11.7.1/AcuantInitializerService.wasm
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantInitializerWorker.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantJavascriptWebSdk.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantMetricsService.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added public/acuant/11.7.1/AcuantMetricsService.wasm
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantMetricsWorker.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

261 changes: 261 additions & 0 deletions public/acuant/11.7.1/AcuantPassiveLiveness.min.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions spec/javascripts/packages/document-capture/components/acuant-sdk-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
*
*/
import { JSDOM } from 'jsdom';
import AcuantJavascriptWebSdk from '../../../../../public/acuant/11.7.0/AcuantJavascriptWebSdk.min.js';
import AcuantJavascriptWebSdk from '../../../../../public/acuant/11.7.1/AcuantJavascriptWebSdk.min.js';

const sdkPaths = {
'11.7.0': '../../../../../public/acuant/11.7.0/AcuantJavascriptWebSdk.min.js',
'11.7.1': '../../../../../public/acuant/11.7.0/AcuantJavascriptWebSdk.min.js',
Comment thread
eric-gade marked this conversation as resolved.
Outdated
};

const TEST_URL = `file://${__dirname}/index.html`;
Expand All @@ -25,14 +25,14 @@ describe('Acuant SDK Loading Tests', () => {
it('Can load something from the SDK file', () => {
expect(AcuantJavascriptWebSdk).to.exist();
});
describe('DOM Loading 11.7.0', () => {
describe('DOM Loading 11.7.1', () => {
before((done) => {
const scriptEl = document.createElement('script');
scriptEl.id = 'test-acuant-sdk-script';
scriptEl.onload = () => {
done();
};
scriptEl.src = sdkPaths['11.7.0'];
scriptEl.src = sdkPaths['11.7.1'];
document.body.append(scriptEl);
});
it('There is a script element in the DOM', () => {
Expand Down