Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/packages/document-capture/context/acuant.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ const getActualAcuantCamera = (): AcuantCameraInterface => {
};

function AcuantContextProvider({
sdkSrc = '/acuant/11.7.0/AcuantJavascriptWebSdk.min.js',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never followed-up with a pull request to remove 11.5.0 after the last upgrade. Can we plan to preemptively get the pull request ready to remove this old version (along with 11.5.0) so it doesn't fall off our radar?

cameraSrc = '/acuant/11.7.0/AcuantCamera.min.js',
sdkSrc = '/acuant/11.7.1/AcuantJavascriptWebSdk.min.js',
cameraSrc = '/acuant/11.7.1/AcuantCamera.min.js',
credentials = null,
endpoint = null,
glareThreshold = DEFAULT_ACCEPTABLE_GLARE_SCORE,
Expand Down
1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantCamera.min.js

This file was deleted.

1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantImageService.min.js

This file was deleted.

Binary file removed public/acuant/11.5.0/AcuantImageService.wasm
Binary file not shown.
1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantImageWorker.min.js

This file was deleted.

1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantInitializerService.min.js

This file was deleted.

Binary file removed public/acuant/11.5.0/AcuantInitializerService.wasm
Binary file not shown.
1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantInitializerWorker.min.js

This file was deleted.

1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantJavascriptWebSdk.min.js

This file was deleted.

Binary file removed public/acuant/11.5.0/AcuantMetricsService.js.mem
Binary file not shown.
1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantMetricsService.min.js

This file was deleted.

1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantMetricsWorker.min.js

This file was deleted.

1 change: 0 additions & 1 deletion public/acuant/11.5.0/AcuantPassiveLiveness.min.js

This file was deleted.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantCamera.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantImageService.min.js

Large diffs are not rendered by default.

Binary file added public/acuant/11.7.1/AcuantImageService.wasm
Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantImageWorker.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantInitializerService.min.js

Large diffs are not rendered by default.

Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantInitializerWorker.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantJavascriptWebSdk.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantMetricsService.min.js

Large diffs are not rendered by default.

Binary file added public/acuant/11.7.1/AcuantMetricsService.wasm
Binary file not shown.
1 change: 1 addition & 0 deletions public/acuant/11.7.1/AcuantMetricsWorker.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

261 changes: 261 additions & 0 deletions public/acuant/11.7.1/AcuantPassiveLiveness.min.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
*
*/
import { JSDOM } from 'jsdom';
import AcuantJavascriptWebSdk from '../../../../../public/acuant/11.7.0/AcuantJavascriptWebSdk.min.js';
import AcuantJavascriptWebSdk from '../../../../../public/acuant/11.7.1/AcuantJavascriptWebSdk.min.js';

const sdkPaths = {
'11.7.0': '../../../../../public/acuant/11.7.0/AcuantJavascriptWebSdk.min.js',
'11.7.1': '../../../../../public/acuant/11.7.1/AcuantJavascriptWebSdk.min.js',
};

const TEST_URL = `file://${__dirname}/index.html`;
Expand All @@ -25,14 +25,14 @@ describe('Acuant SDK Loading Tests', () => {
it('Can load something from the SDK file', () => {
expect(AcuantJavascriptWebSdk).to.exist();
});
describe('DOM Loading 11.7.0', () => {
describe('DOM Loading 11.7.1', () => {
before((done) => {
const scriptEl = document.createElement('script');
scriptEl.id = 'test-acuant-sdk-script';
scriptEl.onload = () => {
done();
};
scriptEl.src = sdkPaths['11.7.0'];
scriptEl.src = sdkPaths['11.7.1'];
document.body.append(scriptEl);
});
it('There is a script element in the DOM', () => {
Expand All @@ -42,10 +42,10 @@ describe('Acuant SDK Loading Tests', () => {
it('Has a global loadAcuantSdk object on the window', () => {
expect(window.loadAcuantSdk).to.exist();
});
it('Calling loadAcuantSdk gives us AcuantJavascriptWebSdk in the global scope, but not as a prop of the window', () => {
it('Calling loadAcuantSdk gives us AcuantJavascriptWebSdk in the global scope and as a prop of the window', () => {
window.loadAcuantSdk();
expect(AcuantJavascriptWebSdk).to.exist();
expect(window.AcuantJavascriptWebSdk).to.not.exist();
expect(window.AcuantJavascriptWebSdk).to.exist();
});
});
});