Merged
Conversation
* Adds proofing session Why: Need to track asyn proofing session to accurately track proofing process changelog: Internal, Inherited Proofing, We are Retrieving API call * Update app/services/idv/steps/inherited_proofing/agreement_step.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Add content warning * Add alert component to webauthn platform setup page * Move alert * Add translations * Add spec changelog: Improvements, User experience, Add alert to Webauthn Platform setup page [LG-7745] * Change spacing * Change margin
The selfie is used to support strict IAL2. The strict IAL2 flow is being retired so we will not be matching selfies here in the near term. This commit retires the code that passes the selfie through the IdV agent to the document proofing job and to the SDK adapter since it is no longer an active code path. [skip changelog]
* Remove liveness check from ApiDocumentVerification [skip changelog] * remove selfie_image_iv
) * Remove DOC_AUTH constant * Document actions * Update tests to include analytics_id * alphabetize * Add inherited proofing stubs * Add optional steps for inherited proofing * Remove check for nil @analytics_ids so we always generate events (#7213) changelog: Internal, Logging, Document doc auth analytics events
…#7219) * Remove selfie and liveness from ApiImageUploadForm and relevant specs * [skip changelog] * Add comma to make linter happy
Removed IAL2 strict code from AuthorizationController and OpenIDConnectAuthorizeForm
* changelog: Improvements, In-Person Proofing, uses correct error handling * changelog: Improvements, In-Person Proofing, adds method for ArcGIS API findAddressCandidates * Add error states, comments, and renaming * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * Update app/services/arcgis_api/geocoder.rb Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * Simplify test and location coordinates data structure Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
* Implement language picker as design system accordion changelog: Internal, Performance, Reduce JavaScript bundle size in critical paths * Convert language picker to ViewComponent * Add specs for LanguagePickerComponent * Flatten markup by assigning class on component * Use dig for property lookup Safer for intermediate nil handling See: #7188 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Increase focus offset for language picker links Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
…n the USPS polling job (#7212) * rename shared examples for easier searching * add testing for error response message * pass the correct hash for bad request errors * Get specs running clean. Minor cleanups * Restructure error handling with more error types * Begin logging status code for HTTP errors * Resolve todos * Get rid of unnecessary variable * Fix broken proofer spec * Update stub name to fix broken spec * Move NewRelic reporting into handler methods * Get rid of unnecessary safe-navigation op * Remove weird status code fallback check The behavior doesn't match the other Faraday behavior for other error types so it feels weird to rely on it just for ParsingError cases * Add disclaimer comment Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
aduth
approved these changes
Oct 27, 2022
* Collapse language picker by default changelog: Bug Fixes, Page Layout, Avoid flickering language picker appearance on page load * Add spec for language picker accessible relation * Add spec for language options (cherry picked from commit 1b71195)
Contributor
We can leave this out of the release notes since the refactor that introduced the regression would have first appeared in this release anyways, so it was never an issue affecting users. |
Contributor
Author
it has been removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Internal