Remove check for nil @analytics_ids so we always generate events#7213
Merged
zachmargolis merged 2 commits intomargolis-explicit-doc-auth-analyticsfrom Oct 25, 2022
Merged
Conversation
4 tasks
zachmargolis
added a commit
that referenced
this pull request
Oct 25, 2022
) * Remove DOC_AUTH constant * Document actions * Update tests to include analytics_id * alphabetize * Add inherited proofing stubs * Add optional steps for inherited proofing * Remove check for nil @analytics_ids so we always generate events (#7213) changelog: Internal, Logging, Document doc auth analytics events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this is a separate branch so I can see what breaks in the whole codebase)
See #7191 for the main changes, this is a branch-to-branch PR