Skip to content

Add notification to Webauthn Platform setup page#7195

Merged
mdiarra3 merged 8 commits intomainfrom
LG-7745-create-content-warning
Oct 25, 2022
Merged

Add notification to Webauthn Platform setup page#7195
mdiarra3 merged 8 commits intomainfrom
LG-7745-create-content-warning

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Oct 24, 2022

🎫 Ticket

Adds an alert to the Webauthn Platform setup page.

Create content for warning to users

Testing

For testing, visit the URL /webauthn_setup?platform=true to see the change.

@jc-gsa jc-gsa requested a review from a team October 24, 2022 14:43
@jmdembe
Copy link
Contributor

jmdembe commented Oct 24, 2022

Small nit: So that we have fuller records on PRs, can you add the information as laid out on the PR template?

@mitchellhenke
Copy link
Contributor

Can you add screenshots showing the difference too? 🙂

@jc-gsa jc-gsa force-pushed the LG-7745-create-content-warning branch from 7721906 to ed4fb26 Compare October 24, 2022 15:22
@jc-gsa
Copy link
Contributor Author

jc-gsa commented Oct 24, 2022

English
en

Spanish
es

French
fr

changelog: Improvements, User experience, Add alert to Webauthn Platform setup page [LG-7745]
@jc-gsa jc-gsa force-pushed the LG-7745-create-content-warning branch from ed4fb26 to 25bebc5 Compare October 24, 2022 15:39
@jc-gsa jc-gsa force-pushed the LG-7745-create-content-warning branch from 3dafd5d to 05729dc Compare October 24, 2022 20:14
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdiarra3 mdiarra3 merged commit 1549b9d into main Oct 25, 2022
@mdiarra3 mdiarra3 deleted the LG-7745-create-content-warning branch October 25, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants