Implement language picker as design system accordion#7188
Merged
Conversation
aduth
commented
Oct 21, 2022
aduth
force-pushed
the
aduth-language-picker
branch
from
a9eabd6 to
c0357fd
Compare
nickttng
approved these changes
Oct 24, 2022
changelog: Internal, Performance, Reduce JavaScript bundle size in critical paths
Safer for intermediate nil handling See: #7188 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
aduth
force-pushed
the
aduth-language-picker
branch
from
dfac960 to
2bf1780
Compare
Contributor
Author
|
Made a minor focus improvement in 2bf1780 to restore the offset which exists in the current production implementation. (It could probably be further improved, mostly concerned with not introducing a regression at this point)
|
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This pull request revises the language picker to leverage existing design system accordion behaviors, replacing an ad hoc implementation. This is similar to what had been implemented in the brochure site in GSA-TTS/identity-site#674 .
Benefits include:
aria-controls)app/javascript/appfolder toward eventually eliminating the folder👀 Screenshots
While the intent was to keep the appearance of the language picker largely the same, I tried to strike a balance with aligning to the brochure site language picker and simplifying the styling overall, which resulted in some minor changes.
Open to any and all suggestions!
Mobile:
Desktop: