Skip to content

LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)#7144

Merged
gangelo merged 3 commits intomainfrom
lg-7446-create-cancel-links-2-of-n
Oct 17, 2022
Merged

LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)#7144
gangelo merged 3 commits intomainfrom
lg-7446-create-cancel-links-2-of-n

Conversation

@gangelo
Copy link
Contributor

@gangelo gangelo commented Oct 13, 2022 •
edited
Loading

See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)

🎫 Ticket

LG-7446

🛠 Summary of changes

NOTE: This is feature branch 2 of what most likely be (at most) several feature branches.

In this feature branch:

  • Implement InheritedProofingCancellationsController #new, #update and #destroy actions.
  • Create specs for the aforementioned controller actions.

Miscellaneous

  • Segregate Inherited Proofing routes in routes.rb.
  • Rename AllowWhitelistedFlowStepConcern to AllowlistedFlowStepConcern based on previous PR feedback.
  • Refactor InheritedProofingCancellationsController#flow_step_whitelist to return Strings for comparison with params[:step] instead of Symbols.

In subsequent feature branch(es):

  • Implement "Cancel" links on appropriate views to initiate the cancellation process in app/views/idv/inherited_proofing_cancellations/new.html.erb view.
  • Create routes for InheritedProofingSessionsController controller actions.
  • Create InheritedProofingSessionsController controller to handle Inherited Proofing (IP) session clean up for cancellation process "Start Over" logic.
  • Create specs and feature specs for the aforementioned.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Automated tests.
  • Manual testing via Sinatra app (when feature branch that includes "Cancel" links in appropriate views are completed).

👀 Screenshots

TODO

🚀 Notes for Deployment

See PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)

@gangelo gangelo added the inherited proofing Pull Requests for the Inherited Proofing feature label Oct 13, 2022
@gangelo gangelo self-assigned this Oct 13, 2022
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-2-of-n branch 8 times, most recently from 9ed4b5d to bf7b9ad Compare October 14, 2022 14:43
@gangelo gangelo marked this pull request as ready for review October 14, 2022 15:01
@gangelo gangelo requested review from aduth, jmhooper and mitchellhenke and removed request for mitchellhenke October 14, 2022 15:02
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-2-of-n branch from bf7b9ad to b680bef Compare October 14, 2022 18:18
@gangelo gangelo requested a review from zachmargolis October 14, 2022 18:34
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-2-of-n branch from b680bef to b4b0f54 Compare October 14, 2022 18:52
@gangelo gangelo mentioned this pull request Oct 14, 2022
Merged
2 tasks
aduth
aduth approved these changes Oct 14, 2022
View reviewed changes
@gangelo
Segregate Inherited Proofing routes
25469be 
changelog: Improvements, Upcoming Features, LG-7446 Create Inherited Proofing Cancellation Links and Process
@gangelo
Rename concern to avoid whitelist in naming
a896492 
- Flow step whitelist should be compared as strings
so this was changed as well.
- ...not Symbols, because they will be compared against
params[:step] which will be a String value.
- Remove unnecessary code
@gangelo
Add InheritedProofingCancellationsController specs
0de8ff6
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-2-of-n branch from b4b0f54 to 0de8ff6 Compare October 17, 2022 12:18
@gangelo gangelo merged commit 8560940 into main Oct 17, 2022
@gangelo gangelo deleted the lg-7446-create-cancel-links-2-of-n branch October 17, 2022 13:00
@mdiarra3 mdiarra3 mentioned this pull request Oct 17, 2022
Merged
mdiarra3 added a commit that referenced this pull request Oct 17, 2022
@mdiarra3 @gangelo
@aduth @zachmargolis @julialeague @solipet @allthesignals
Deploy RC 218 to Prod (#7151)
34a2644 
* LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n) (#7124)

* Create concern to render 404 if

The IdentityConfig.store.inherited_proofing_enabled returns false in
preparation for use in the Inherited Proofing (IP) cancellations controller
that needs to be created. Eventually, this code may get thrown away
once IP goes live; however, this makes for less lines of code that
need to be removed once/if it does.

changelog: Improvements, Upcoming Features, LG-7446 Create Inherited Proofing Cancellation Links and Process

* Add skeleton InheritedProofingCancellationsController

Specs to be added in subsequent PR when controller actions
are fleshed out.

* Add InheritedProofingCancellationsController views and i18n

* Add routes for InheritedProofingCancellationsController actions

* Satisfy Brakeman violations

Specifically, the "Render path contains parameter value" violation.

This commit whitelists the flow steps expected and raises an error
if params[:step] is not found in the whitelist.

Confidence: Weak
Category: Dynamic Render Path
Check: Render
Message: Render path contains parameter value
Code: render(action => ButtonComponent.new(:action =>
  (lambda do  button_to(idv_inherited_proofing_cancel_path(:step => params[:step]),
  { **tag_options }, &block)  end), :method => :put, :big => true, :wide => true,
  :outline => true).with_content(t("inherited_proofing.cancel.actions.keep_going")), {})
File: app/views/idv/inherited_proofing_cancellations/new.html.erb
Line: 23

Confidence: Weak
Category: Dynamic Render Path
Check: Render
Message: Render path contains parameter value
Code: render(action => SpinnerButtonComponent.new(:action =>
  (lambda do  button_to(idv_inherited_proofing_cancel_path(:step => params[:step],
  :location => "cancel"), { **tag_options }, &block)  end), :method => :delete,
  :big => true, :wide => true, :outline => true,
  :form => ({ :data => ({ :form_steps_wait => "" }) }))
  .with_content(CancellationsPresenter.new(:sp_name =>
  decorated_session.sp_name, :url_options => url_options).exit_action_text), {})
File: app/views/idv/inherited_proofing_cancellations/new.html.erb
Line: 44

* Remove unused analytics events (#7142)

changelog: Internal, Analytics, Remove unused analytics events

* Remove JavaScript optimization from asset pipeline (#7136)

changelog: Internal, Build Tooling, Remove redundant JavaScript optimization step

* Remove unused support for proc methods in frontend logger (#7143)

changelog: Internal, Analytics, Remove unused feature support in frontend logger

Last usages removed in #7110

* Ensure all UserMailer emails do not use plaintext emails as parameters (#7106)

* Ensure all UserMailer emails have matching User and EmailAddress parameters and plaintext emails are not used as parameters

changelog: Internal, Email, Ensure all UserMailer emails have matching User and EmailAddress parameters and plaintext emails are not used as parameters

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* fix mailer previews

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Prepare to drop unused registration_logs columns (LG-6317) (#7131)

- Make registration_logs.submitted_at nullable, stop writing it
- Ignore other columns

changelog: Internal, Logging, Stop writing extra registration_logs timestamps

* LG-7251 Update SAML SP request flow to POST internally instead of GET (#6894)

* Update SAML SP request flow to POST internally instead of GET

* Add route for internal SAML auth POST requests

* changelog: Improvements, Service Provider Authentication, Update SAML Authentication Flow

* Add feature flag for SAML internal POST update, tests for the flag

* Allow longer wait delay for in-person feature specs (#7145)

**Why**: Clicking "Continue" from the "prepare" step will wait for a client-side logging event before continuing to the "State ID" step, which often cannot complete before the 0.5 second tolerance allowed by default in local development environments.

changelog: Internal, Automated Testing, Improve reliability of feature specs

* LG-7702: record the issuer of the SP requesting idv in the profile. (#7125)

* LG-7702: record the issuer of the SP requesting idv in the profile.

changelog: Internal, Identity Verification, Track the agency requesting identity verification.

* record the initiating sp as an association
* use the issuer as the foreign key

* changelog: Improvements, In-Person Proofing, updates translations in french and spanish (#7139)

* LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n) (#7144)

* Segregate Inherited Proofing routes

changelog: Improvements, Upcoming Features, LG-7446 Create Inherited Proofing Cancellation Links and Process

* Rename concern to avoid whitelist in naming

- Flow step whitelist should be compared as strings
so this was changed as well.
- ...not Symbols, because they will be compared against
params[:step] which will be a String value.
- Remove unnecessary code

* Add InheritedProofingCancellationsController specs

Co-authored-by: Gene M. Angelo, Jr <web.gma@gmail.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Julia Allen <51330839+julialeague@users.noreply.github.com>
Co-authored-by: Doug Price <douglas.price@gsa.gov>
Co-authored-by: Matt Gardner <wilburnforce@gmail.com>
@gangelo gangelo mentioned this pull request Oct 19, 2022
Merged
2 tasks
@mdiarra3 mdiarra3 mentioned this pull request Oct 20, 2022
Closed
@mdiarra3 mdiarra3 mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmhooper jmhooper Awaiting requested review from jmhooper

@zachmargolis zachmargolis Awaiting requested review from zachmargolis

1 more reviewer

@aduth aduth aduth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gangelo gangelo

Labels

inherited proofing Pull Requests for the Inherited Proofing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gangelo @aduth