Skip to content

LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (3 of n)#7148

Merged
gangelo merged 5 commits intomainfrom
lg-7446-create-cancel-links-3-of-n
Oct 18, 2022
Merged

LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (3 of n)#7148
gangelo merged 5 commits intomainfrom
lg-7446-create-cancel-links-3-of-n

Conversation

@gangelo
Copy link
Contributor

@gangelo gangelo commented Oct 14, 2022

NOTE: Ignore the first 3 commits, as they are part of the lg-7446-create-cancel-links-2-of-n branch this branch was branched off of, and will go away once that branch is merged into main, and this branch is rebased on top if it

See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)
See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)

🎫 Ticket

LG-7446

🛠 Summary of changes

NOTE: This is feature branch 3 of what most likely be (at most) several feature branches.

In this feature branch:

  • Implement "Cancel" links on :agreement and :get_started step views to initiate the cancellation process in app/views/idv/inherited_proofing_cancellations/new.html.erb view.
  • Create InheritedProofingSessionsController controller to handle Inherited Proofing (IP) session clean up for cancellation process "Start Over" logic.
    • Create routes for InheritedProofingSessionsController controller actions.
  • Create specs and feature specs for all of the aforementioned.

In subsequent feature branch(es):

  • Implement "Cancel" links on all other IP step views besides the :agreement and :get_started step views, to initiate the cancellation process in app/views/idv/inherited_proofing_cancellations/new.html.erb view
    The "Start Over" cancellation logic that involves the InheritedProofingSessionsController controller and associated specs and feature specs will be in a subsequent (and final) feature branch.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Automated tests.
  • Manual testing via Sinatra app (when feature branch that includes "Cancel" links in appropriate views are completed).

👀 Screenshots

Before: ![get_started_before](https://user-images.githubusercontent.com/346917/196483550-d8bd13f6-cb9d-449f-b21f-2b1e6baec456.png) ![agreement_before](https://user-images.githubusercontent.com/346917/196483614-5b9b6960-4924-4dfb-99f0-0f7e0357b142.png)
After: ![get_started_after](https://user-images.githubusercontent.com/346917/196483694-9a830097-8baf-41a5-9075-c830d702fbd6.png) ![agreement_after](https://user-images.githubusercontent.com/346917/196483713-60c57c88-8656-49cf-b9f8-2e745930e07a.png) ![cancel](https://user-images.githubusercontent.com/346917/196483737-877b7dd3-fc5c-41b0-bbf2-4708381898e7.png)

🚀 Notes for Deployment

See PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)

@gangelo gangelo self-assigned this Oct 14, 2022
@gangelo gangelo added the inherited proofing Pull Requests for the Inherited Proofing feature label Oct 14, 2022
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-3-of-n branch 4 times, most recently from 2da28a4 to 0fddef4 Compare October 17, 2022 17:13
changelog: Upcoming Features, Inherited Proofing, LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (3 of n)
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-3-of-n branch from 0fddef4 to 00adf5d Compare October 18, 2022 13:42
@gangelo gangelo marked this pull request as ready for review October 18, 2022 15:45
@gangelo gangelo requested a review from jmhooper October 18, 2022 15:45
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-3-of-n branch from 00adf5d to 192c3ad Compare October 18, 2022 15:51
@gangelo gangelo force-pushed the lg-7446-create-cancel-links-3-of-n branch from 192c3ad to 85e7611 Compare October 18, 2022 16:11
@gangelo gangelo merged commit b0e1dba into main Oct 18, 2022
@gangelo gangelo deleted the lg-7446-create-cancel-links-3-of-n branch October 18, 2022 16:36
This was referenced Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inherited proofing Pull Requests for the Inherited Proofing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants