Remove unused analytics events

[aduth]

🛠 Summary of changes

Removes analytics events which are no longer used. These were last referenced prior to #7110.

I put together a small script to try to find any other unused, these were the only ones.

cat app/services/analytics_events.rb | perl -n -e '/def ([a-z_]+)/ && print "$1\n"' | while read LINE; do
  count=$(grep --recursive -o $LINE app | wc -l)
  if [ "$count" -eq "1" ]; then
    echo $LINE
  fi
done

📜 Testing Plan

Automated tests should pass.

[aduth]

I put together a small script to try to find any other unused, these were the only ones.

It'd be nice to have some automated check as part of continuous integration, but I think this one ain't it. It's pretty slow to run, and inefficient. Ideally we'd do a single pass over all the app files, vs. this script which runs over them all for each analytics method.

[zachmargolis]

Removes analytics events which are no longer used. These were last referenced prior to #7110.

Just to confirm I also grepped for the string names in identity-devops to make sure they weren't being used as part of any dashboards, they seem not to be.

And neither of these are good candidates for the previous_event_name right? Like there are no new events that corelate to these since we got rid of the modal?

[aduth]

Just to confirm I also grepped for the string names in identity-devops to make sure they weren't being used as part of any dashboards, they seem not to be.

And neither of these are good candidates for the previous_event_name right? Like there are no new events that corelate to these since we got rid of the modal?

Thanks for checking. These methods were part of FSMv2, so they'd have never been live for real users in production, hence I'm not sure if we'd care to set up previous_event_names since we have no analytics data we'd want to maintain. FSMv2 worked a bit differently in treating the "confirm" (modal) as a distinct step. In the production implementation, the effective equivalent events to these are "Frontend: IdV: show personal key modal" and "IdV: personal key submitted".

identity-idp/spec/features/idv/analytics_spec.rb

Lines 41 to 42 in 64149e6

	'IdV: personal key submitted' => {},
	'Frontend: IdV: show personal key modal' => {},