Skip to content

Fix link in email when confirming new email address for existing account #7019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 22, 2022
Merged

Fix link in email when confirming new email address for existing account #7019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/user_mailer/add_email.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

<p>
<%= link_to add_email_confirmation_url(_request_id: @request_id, confirmation_token: @token, locale: @locale),
sign_up_create_email_confirmation_url(
add_email_confirmation_url(
Comment on lines 38 to +39
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 what if we assigned @add_email_url in the mailer, and then re-used that variable here in the template instead of re-creating it 3 times, risking having different results? (I can also make a follow-up PR)

Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm good with that

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7021

_request_id: @request_id,
confirmation_token: @token,
locale: @locale,
Expand Down