Add instructional text to the 2FA setup screen

[theresaanna]

Why:

• Presumably, users found it confusing before

What:

• Adds emphasis to first part of info paragraph
• Adds instructional text to each form field
• Moves the label string for the phone field out of the view and into a translation string

Visual:

[jessieay]

Looks awesome! One comment about using HTML within I18n.

[jessieay]

I18n protip: we can keep this lead text in the same translation and bold it by taking advantage of I18n's built-in HTML support.

How:

append _html to the translation name (so this would be otp_setup_html), and add the css you need into the translation inline. Like this:

<strong>Every time you log in,</strong> we will send you a one-time passcode via text we will send you a one-time passcode via text message or phone call. This helps safeguard your account.

The Rails view will automatically interpret this string as HTML now. (don't forget to also change the key in the view to be = t('devise.two_factor_authentication.otp_setup_html')

[theresaanna]

Thanks, that's great to know! Will implement. 👍

[monfresh]

To me, "any time" implies that there is a setting where they can change their choice, even after authenticating, but we don't have that feature. The only times they can make a choice are:

• right before they are about to receive an OTP, such as on the phone setup screen or on the delivery method screen
• when already having received an OTP and deciding they want to change the delivery method ("call me with the code instead", or "text me the code instead")

[brendansudol]

you're right @monfresh but I feel like that subtle difference is fine here

[theresaanna]

Perhaps we should ask @esgoodman and @jeanninehunter to weigh in here? What do each of you think about this language given the feature set?

[esgoodman]

All good points. However, I can easily see how we might be more precise without destroying plain language simplicity. Let's go with this for otp_method.instruction:

You can change your choice the next time you sign in

cc @jeanninehunter

[theresaanna]

Changes implemented! Ready for a second review.