Skip to content

Add instructional text to the 2FA setup screen #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfresh merged 1 commit into from
Nov 8, 2016
Merged

Add instructional text to the 2FA setup screen #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/views/devise/two_factor_authentication_setup/index.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,25 @@


h1.h3.my0 = t('devise.two_factor_authentication.two_factor_setup')
p.mt-tiny.mb0#2fa-description = t('devise.two_factor_authentication.otp_setup')
p.mt-tiny.mb0#2fa-description
= t('devise.two_factor_authentication.otp_setup_html')
= simple_form_for(@two_factor_setup_form,
html: { autocomplete: 'off', role: 'form' },
method: :patch,
url: phone_setup_path) do |f|
= f.error_notification
= f.input :phone, as: :tel, label: 'Phone Number', required: true,
input_html: { 'aria-describedby' => '2fa-description' }
= f.label :phone, class: 'block'
strong.left = t('devise.two_factor_authentication.otp_phone_label')
span.ml1.italic = t('devise.two_factor_authentication.otp_phone_label_info')
= f.input :phone, as: :tel, label: false, required: true,
input_html: { 'aria-describedby' => '2fa-description' }
.mb3
= label_tag 'two_factor_setup_form[otp_method]',
t('devise.two_factor_authentication.otp_method.title'),
class: 'block bold'
= label_tag 'two_factor_setup_form[otp_method]',
t('devise.two_factor_authentication.otp_method.instruction'),
class: 'block'
label.radio.mb0.mr3
= radio_button_tag 'two_factor_setup_form[otp_method]', :sms,
checked: true
Expand Down
7 changes: 5 additions & 2 deletions config/locales/devise/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ en:
recovery_code_fallback:
text: Don’t have access to your phone? Use a %{link} instead.
link: recovery code
otp_setup: >
Every time you log in, we will send you a one-time passcode via text
otp_phone_label: Phone number
otp_phone_label_info: Mobile or landline okay
otp_setup_html: >
<strong>Every time you log in,</strong> we will send you a one-time passcode via text
message or phone call. This helps safeguard your account.
choose_delivery_confirmation: >
Please select how you would like to receive your confirmation code for %{phone}
Expand Down Expand Up @@ -150,5 +152,6 @@ en:
confirm_with_voice: Confirm with voice call
otp_method:
title: How would you like to receive your passcode?
instruction: You can change your choice the next time you sign in
sms: Text message (SMS)
voice: Phone call