Update saml_idp with better logic for matching_cert#5220
Merged
zachmargolis merged 2 commits intomainfrom Jul 21, 2021
Merged
Conversation
zachmargolis
commented
Jul 19, 2021
| nil | ||
| elsif current_service_provider&.encrypt_responses? | ||
| cert = saml_request.service_provider.matching_cert || | ||
| current_service_provider&.ssl_certs&.first |
Contributor
Author
There was a problem hiding this comment.
the .first was masking an issue where we couldn't find a matching cert, so we sent back a wrong cert... this may cause some nil errors in the specs, will see how it goes
Contributor
Author
There was a problem hiding this comment.
good news, removing this didn't break the build so it didn't cause a regression that we know about
orenyk
approved these changes
Jul 21, 2021
Contributor
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
Looks good to me once 18F/saml_idp#46 is merged in. Great work!
juliasolorzano
pushed a commit
that referenced
this pull request
Jul 22, 2021
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 22, 2021
juliasolorzano
pushed a commit
that referenced
this pull request
Jul 23, 2021
* Updating capitalization of login.gov to Login.gov. * Updating ASCII because fun is important. * Fixin dat YAML. * MOAR YML! * Update config/locales/user_mailer/es.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update config/locales/user_mailer/es.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update config/locales/user_mailer/es.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update config/locales/user_mailer/fr.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update vendor/assets/javascripts/local-time.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update vendor/assets/javascripts/local-time.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update vendor/assets/javascripts/local-time.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update saml_idp with better logic for matching_cert (#5220) * Bring back a default cert, to fix NoMethodErrors on nil (#5224) * Add regression spec for NoMethodError * Remove .erdconfig (#5226) **Why**: We removed the ERD in #4960 * Update APP_NAME in application.rb. * Revert Gemfile.lock. * Update config/locales/idv/fr.yml Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update Gemfile Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Run `make normalize_yaml` * Update spec that used lowercase login to use uppercase Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See 18F/saml_idp#46