Skip to content

Remove stale architecture doc and supporting diagrams#4960

Merged
jmhooper merged 2 commits intomainfrom
jmhooper-remove-old-architecture-docs
Apr 22, 2021
Merged

Remove stale architecture doc and supporting diagrams#4960
jmhooper merged 2 commits intomainfrom
jmhooper-remove-old-architecture-docs

Conversation

@jmhooper
Copy link
Contributor

Why: These diagrams are no longer correct and aren't being maintained. Going forward this sort of documentation is maintained at https://handbook.login.gov#appdev

**Why**: These diagrams are no longer correct and aren't being maintained. Going forward this sort of documentation is maintained at https://handbook.login.gov#appdev
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit 47020c9 into main Apr 22, 2021
@jmhooper jmhooper deleted the jmhooper-remove-old-architecture-docs branch April 22, 2021 19:14
jmhooper added a commit that referenced this pull request Jul 22, 2021
**Why**: We removed the ERD in #4960
@jmhooper jmhooper mentioned this pull request Jul 22, 2021
jmhooper added a commit that referenced this pull request Jul 22, 2021
**Why**: We removed the ERD in #4960
juliasolorzano pushed a commit that referenced this pull request Jul 22, 2021
**Why**: We removed the ERD in #4960
mitchellhenke pushed a commit that referenced this pull request Jul 22, 2021
**Why**: We removed the ERD in #4960
juliasolorzano pushed a commit that referenced this pull request Jul 23, 2021
* Updating capitalization of login.gov to Login.gov.

* Updating ASCII because fun is important.

* Fixin dat YAML.

* MOAR YML!

* Update config/locales/user_mailer/es.yml

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update config/locales/user_mailer/es.yml

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update config/locales/user_mailer/es.yml

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update config/locales/user_mailer/fr.yml

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update vendor/assets/javascripts/local-time.js

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update vendor/assets/javascripts/local-time.js

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update vendor/assets/javascripts/local-time.js

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Update saml_idp with better logic for matching_cert (#5220)

* Bring back a default cert, to fix NoMethodErrors on nil (#5224)

* Add regression spec for NoMethodError

* Remove .erdconfig (#5226)

**Why**: We removed the ERD in #4960

* Update APP_NAME in application.rb.

* Revert Gemfile.lock.

* Update config/locales/idv/fr.yml

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Update Gemfile

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Run `make normalize_yaml`

* Update spec that used lowercase login to use uppercase

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants