LG-6308: Show correct step indicator steps in in-person flow#6846
Merged
LG-6308: Show correct step indicator steps in in-person flow#6846
Conversation
aduth
commented
Aug 26, 2022
aduth
force-pushed
the
aduth-lg-6308-step-indicator-steps
branch
from
b277dda to
1b7b686
Compare
aduth
changed the base branch from
main
to
aduth-lg-6307-step-indicator-pending
aduth
force-pushed
the
aduth-lg-6307-step-indicator-pending
branch
from
396506c to
fba1bf0
Compare
aduth
force-pushed
the
aduth-lg-6308-step-indicator-steps
branch
2 times, most recently
from
2ee8e8c to
123145d
Compare
aduth
commented
Sep 1, 2022
Comment on lines
6
to
13
Contributor
Author
There was a problem hiding this comment.
Notes on the changes here:
- I removed the protocol-specific test repetition, consistent with previous changes in Try limiting IdV cancellation shared examples to single SP #6404 to improve feature spec performance
- As part of this, I moved the shared example code into this spec file, to be run once.
- The "GPO proofing disabled" context wasn't doing what it claimed to be doing, since it never set up the actual contextual variation.
- I added a new "with gpo feature disabled" to the spec file which actually disables the feature to test that a user can still verify their profile.
aduth
requested review from
a team,
kellular and
sheldon-b
and removed request for
a team
tomas-nava
approved these changes
Sep 1, 2022
Contributor
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
approve! It's a really elegant solution.
I checked the indicator on all the IPP flow pages against the designs and everything lined up!
Base automatically changed from
aduth-lg-6307-step-indicator-pending
to
main
September 2, 2022 14:17
**Why**: As a user going through in-person proofing, I want to see a step indicator at the top of the page that shows me moving forward in the flow, so that it's easy to understand that I'm making progress and what I still need to do. changelog: Upcoming Features, In-person proofing, Show correct step indicator at each step
Helper method for step_indicator_steps
Clean up, simplify diff
This is now the responsibility of the helper
Since it's accessed outside the class
nil.as_json.to_h == nil.to_h
aduth
force-pushed
the
aduth-lg-6308-step-indicator-steps
branch
from
4347992 to
c2cdd6b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #6860
Why: As a user going through in-person proofing, I want to see a step indicator at the top of the page that shows me moving forward in the flow, so that it's easy to understand that I'm making progress and what I still need to do.