Try limiting IdV cancellation shared examples to single SP#6404
Merged
Conversation
zachmargolis
approved these changes
May 24, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I think we do have rare OIDC/SAML mismatch bugs but you're right, this is probably not going to highlight very many
Contributor
Author
Yeah, I did check some of the other OIDC + SAML branching tests, and came to a similar conclusion that we might not want to apply this sort of change broadly, but for this particular set of shared examples, it is most concerned with the presence/absence of an SP, and doesn't assert anything about the specific SP. |
**Why**: To reduce build time, and since the shared behavior isn't really particular about the specific SP, just that there may be different behavior by the mere presence of some SP.
changelog: Internal, Automated Testing, Reduce build time for automated tests
aduth
force-pushed
the
aduth-rm-cancel-at-per-sp
branch
from
0944347 to
e0d48b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To reduce build time, and since the shared behavior isn't really particular about the specific SP, just that there may be different behavior by the mere presence of some SP (see source).