LG-6307: Remove pending steps from step indicator#6860
Merged
Conversation
zachmargolis
approved these changes
Aug 29, 2022
Contributor
There was a problem hiding this comment.
is this the line the eslint-plugin change was for?
Contributor
Author
There was a problem hiding this comment.
is this the line the eslint-plugin change was for?
Yep, sorry, I should have highlighted that connection.
Contributor
Author
There was a problem hiding this comment.
With the previous rule enforced, you'd have to do something like...
let { steps } = FLOW_STEPS_PATH[path];
const { mapping } = FLOW_STEPS_PATH[path];Not only is it kinda garish, I think the general pattern could be problematic in cases such as...
let { foo } = doSomeExpensiveOrMutativeTask();
const { bar } = doSomeExpensiveOrMutativeTask();
It's not always straight-forward to split const/let assignments for a destructure, and since the idea with preferring const is largely around developer experience and communicating intent, the readability benefits of allowing a single destructured "let" assignment outweigh that of enforcing const.
**Why**: As a user, I want to see a step indicator at the top of the page that shows me moving forward in the flow, so that it's easy to understand that I'm making progress and what I still need to do. changelog: Improvements, Identity Verification, Remove pending steps from step indicator
It's now unused. YAGNI!
aduth
force-pushed
the
aduth-lg-6307-step-indicator-pending
branch
from
396506c to
fba1bf0
Compare
anniehirshman-gsa
approved these changes
Sep 2, 2022
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Reviewed in sandbox. Looks great to me too!
Merged
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #6846
Why: As a user, I want to see a step indicator at the top of the page that shows me moving forward in the flow, so that it's easy to understand that I'm making progress and what I still need to do.
Screenshots: