Add a includes_phone_check? method to Profile#6262
Merged
Conversation
The letter flow as it is implemented may not meet the bar for strict IAL2. This commit adds a method for checking whether a letter was used to verify a user to enable building conditionals around that in a future change.
jmhooper
commented
Apr 27, 2022
| expect(profile.proofing_components).to eq('') | ||
| end | ||
|
|
||
| it 'does not blow up in #includes_liveness_check?' do |
Contributor
Author
There was a problem hiding this comment.
I moved this into a dedicated test around #includes_liveness_check?
…l to determine if a user verified their address with a letter or by phone
aduth
added a commit
that referenced
this pull request
Apr 28, 2022
As of #6262, we now check component as "blank?". In the real world, the value would be the vendor name, so add a placeholder value for tests.
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
The letter flow as it is implemented may not meet the bar for strict IAL2. This commit adds a method for checking whether a letter was used to verify a user to enable building conditionals around that in a future change. * changelog: Internal, Proofing, A helper was added to the Profile model to determine if a user verified their address with a letter or by phone
aduth
added a commit
that referenced
this pull request
May 4, 2022
* Use stubbed profile for authorization_count_spec **Why:** - For improved compatibility with JS-enabled proofing, where authorization counts rely on an "Agree and continue" redirect back to the SP. With the JavaScript browser, there is no server to redirect to, resulting in an error. - Improved performance, since proofing involves many steps - To limit the concern of the specs to authorization counts, not to the ability to successfully proof changelog: Internal, Automated Testing, Improve performance of automated tests * Only set PII for verified profile mocks * Require PII opt-in for profile stubs too many tests assume it won't be there (probably a problem worth resolving) * Add non-empty vendor for liveness check component As of #6262, we now check component as "blank?". In the real world, the value would be the vendor name, so add a placeholder value for tests. * Update authorization_count_spec.rb * Remove default PII shouldn't have been here - bad cherry-pick? * Avoid concat for user profile creation See: https://github.com/18F/identity-idp/pull/6255/files#r863108404 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Remove unnecessary user save Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
* Use stubbed profile for authorization_count_spec **Why:** - For improved compatibility with JS-enabled proofing, where authorization counts rely on an "Agree and continue" redirect back to the SP. With the JavaScript browser, there is no server to redirect to, resulting in an error. - Improved performance, since proofing involves many steps - To limit the concern of the specs to authorization counts, not to the ability to successfully proof changelog: Internal, Automated Testing, Improve performance of automated tests * Only set PII for verified profile mocks * Require PII opt-in for profile stubs too many tests assume it won't be there (probably a problem worth resolving) * Add non-empty vendor for liveness check component As of #6262, we now check component as "blank?". In the real world, the value would be the vendor name, so add a placeholder value for tests. * Update authorization_count_spec.rb * Remove default PII shouldn't have been here - bad cherry-pick? * Avoid concat for user profile creation See: https://github.com/18F/identity-idp/pull/6255/files#r863108404 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Remove unnecessary user save Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The letter flow as it is implemented may not meet the bar for strict IAL2. This commit adds a method for checking whether a letter was used to verify a user to enable building conditionals around that in a future change.