Save a ServiceProvider.find query during authentication

[mitchellhenke]

Eventually we'll find them all (followup to #6058, #6061, and #6087)

[zachmargolis]

LGTM

[zachmargolis]

seems like we could move sp_from_request_issuer_logout to the SAML controller, since it depends on saml_request?

[mitchellhenke]

I was trying to untangle a bit, and wasn't sure where to start safely, but that's a good idea. Made an attempt in e45a5c3

Fwiw, this implementation stems from #3460 and #3461, so my understanding is the only thing depending on sp_from_request_issuer_logout should be the redirect uris in unauthenticated SAML logout contexts

[zachmargolis]

just to check my understanding, this isn't saving a query, this is just making a method definition more explicit, right?

[mitchellhenke]

Yeah, I got a bit frustrated trying to find where sp_redirect_uris was defined since it's a few layers beneath decorated_session

[aduth]

Thought: Could we have a spec which asserts that only X queries (1?) are made during an authentication?

[zachmargolis]

Thought: Could we have a spec which asserts that only X queries (1?) are made during an authentication?

one thing I've seen other projects use is hooking into ActiveSupport notifications and tracking queries that way

Maybe we combine the raw SQL with something like this https://github.com/pganalyze/pg_query#extracting-tables-from-a-query

[mitchellhenke]

Thought: Could we have a spec which asserts that only X queries (1?) are made during an authentication?

one thing I've seen other projects use is hooking into ActiveSupport notifications and tracking queries that way

Maybe we combine the raw SQL with something like this https://github.com/pganalyze/pg_query#extracting-tables-from-a-query

I love this idea. I do have some minor worries about making tests too restrictive, but it'd be cool to explore this and see what's possible.