Save a ServiceProvider.find query during two factor authentication#6087
Merged
mitchellhenke merged 1 commit intomainfrom Mar 17, 2022
Merged
Save a ServiceProvider.find query during two factor authentication#6087mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
changelog: Internal, Performance, Re-use existing database query results to avoid duplicative work
mitchellhenke
force-pushed
the
mitchellhenke/save-a-query-4
branch
from
b14f3d6 to
61fdbb9
Compare
zachmargolis
approved these changes
Mar 17, 2022
| @@ -314,6 +314,7 @@ def presenter_for_two_factor_authentication_method | |||
| TwoFactorAuthCode.const_get("#{type}_delivery_presenter".classify).new( | |||
Contributor
There was a problem hiding this comment.
!!!! I do not like this dynamic access.... story for another time
Contributor
Author
There was a problem hiding this comment.
yeahhhhh, this and passing view_context around are things I'd like to change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind of a follow up to #6058 and #6061