Add query tracker that lets us track queries by table#6093
Merged
zachmargolis merged 5 commits intomainfrom Mar 18, 2022
Merged
Add query tracker that lets us track queries by table#6093zachmargolis merged 5 commits intomainfrom
zachmargolis merged 5 commits intomainfrom
Conversation
[skip changelog]
aduth
approved these changes
Mar 18, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Very cool! I think it'd be a useful way to keep ourselves accountable that an extra query in hot flows should be explicit/intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #6091 (comment)
I didn't apply this to any tests yet, but we should be able to to use this in feature tests or controller tests if we wantI just added one example usage, we can add more specific usages if we want to later