Deploy RC 167 to Production#5629
Merged
zachmargolis merged 15 commits intostages/prodfrom Nov 24, 2021
Merged
Conversation
**Why**: Because they're unused.
* Disable options on MFA setup screen * Handle vendor outage for setup, sign-in MFA * Handle full outage for IDV phone verification * Move phone controller redirect to before_action See: #5550 (comment) * Simplify / remove memoization for gpo_letter_available? Currently only ever called once * Update alert partial to component * Add "Get Updates" text * Show single vendor outage status on phone setup page * try a VendorOutageAlertComponent component * Fix missing && * Update MFA to use VendorOutageAlertComponent * Update MFA setup to use VnedorOutageAlertComponent * Update phone setup to use VnedorOutageAlertComponent * Remove lingering TranslationHelper * Restore show_security_level? * Fix VendorStatus#outage_message errors translation helper not available, locale message scope changed * Redirect UsersPhoneController on full phone outage * Move outages sort to content **Why**: Because sort is important only to the case conditions, so it makes most sense to apply there. A "outages' method wouldn't necessarily be expected to sort its results, maybe unless it were called as such e.g. "sorted_outages" * Fix Spanish, French vendor outage string nesting * Disable options on IAL2 phone OTP verify step * Update full outage IAL2 message * Add missing sms default alerts translations * Normalize YAML * Show IAL2 welcome page alert on combined full outage * Show sign-in alert on combined full phone outage * Add default blocked phone translations * Disable phone mfa option when "phone" type outage * Use all_phone_vendor_outage? convenience method * Ensure same page before pulling error from FormStepsWait Because otherwise it will wrongly pull outage message from phone verify * Remove alert banner from MFA setup page during combined outage Per feedback at #5550 (review) * Remove alert banner from IAL2 sign in page Based on feedback at #5550 (review) * Update alert banner text for voice outage Based on feedback from #5550 (review) * Show alert banner on MFA setup page, only during combined outage Reverts 5a98c26, but adds `only_if_both: true` * Add specs for VendorOutageAlertComponent * Fix parameter only_if_both -> only_if_all * Redirect to MFA setup only if MFA not yet set up See: https://github.com/18F/identity-idp/pull/5550/files#r749594533 * Explicitly mark contextual translated keys Because dynamic context isn't natively understood by i18n-tasks * make grammer good * Update tests for FormStepsWait redirect with error * Redirect phone IDV to vendor outage page as part of redirect_to_next_step This is where phone confirmation redirect logic occurs by default * Test VendorOutageController show_gpo_option assignment * Test UsersPhonesController#add redirect on vendor outage * Test TwoFactorAuthenticationController * Test NewPhoneForm * Implement disabled in specific selection presenters Also fixes case where "type" may be concatenated in multiple configuration scenario * Test TwoFactorLoginOptionsPresenter#first_enabled_option_index * Test new VendorStatus methods * Rename IAL2 outage messages to IDV consistency with existing "blocked" messaging * Test IAL2 Welcome step alert * Test IDV OTP delivery method alert, disabled options * Test 2FA options alert, disabled options * Test phone setup phone outage alert * Test add phone outage alert * Test _otp_delivery_preference_selection * Test two_factor_authentication_setup/index * Test vendor_outage/show * Add missing "Get Updates" translations * Add spec for fallback alert message behavior See: #5550 (comment)
#5615) * Change hard coded 'login.gov' to variable/constant. * Add interpolation param for translations. * Normalize yaml files.
* Remove instances of "h1" BassCSS class **Why**: Toward migration off BassCSS to design system. * Render device-choice subheading as h2.font-family-sans
* LG-5393: Upgrade Acuant SDK to v11.5.1 **Why**: So that we're taking advantage of the latest bug fixes and improvements. * Trigger rebuild
* Stream results in IAA supplement report * Stream results in Issuer supplement report **Why**: The big UNION query takes so long it gets serialization errors in prod, so this reworks it to do more logic in Ruby and stream results
**Why**: Because, pending full deploy of RC165, it is no longer in use.
…nt steps. (#5617) LG-5372 Minor content and styling update for IAL2 welcome and agreement steps.
…nt (#5621) * YAML normalization: Fix non-HTML fragment smart punctuation replacement * Normalize YAML * Use argument defaulting for unmatched fallback clearer * Fix outdated, hard-coded translation text
**Why**: So that the specs are actually run, since only files matching "_spec.rb" file suffix are included in the test run.
**Why**: To avoid needing to cherry-pick individual window properties to promote to the global namespace, which often comes as a surprise, and likely won't be clear how to resolve when the need arises. Instead, assign all window properties as global properties, which is essentially how it behaves in a browser environment.
aduth
approved these changes
Nov 23, 2021
Contributor
|
I think this is supposed to be RC 167 (the release from last week is missing?) |
Contributor
Author
whoops, will update |
This reverts commit cc507d0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to deploy on Wednesday this week because of the holiday