Remove instances of "h1" BassCSS class

[aduth]

Why: Toward migration off BassCSS to design system.

The font-sans-lg design system utility class provides a similar font size styling effect (1.5rem with h1 vs. 1.46rem with font-sans-lg). In the future, we may consider avoiding these classes altogether, toward more semantic elements such as headings, or componentizing specific usage such as process lists (LG-4791).

Open Questions:

• The font size for the "Upload" step in the Figma design is 1.25rem, which matches neither h1 nor font-sans-lg. Does that font size correspond to anything meaningful (component, etc)? Should it be customized to match the design, or should the design be updated to use the design system font size token?

(cc @anniehirshman-gsa)

Screenshots:

Screen	Before	After
PIV Setup
IAL2 Device Choice

[zachmargolis]

LGTM

[anniehirshman-gsa]

Thanks for surfacing this! I agree that it'd be good to make these semantic headings even if the large text size changes a little. In fact, I updated the Upload page heading to an h2 in mockups for a design improvement that hasn't been implemented yet (Figma, LG-5196).

The only trick is that with the current font set, h2s are serifs and it would be preferable to keep them sans. Do you have a good suggestion for a temporary fix for that?

[aduth]

The only trick is that with the current font set, h2s are serifs and it would be preferable to keep them sans. Do you have a good suggestion for a temporary fix for that?

Yeah, we can use the font-family-sans utility class to force it to render in sans-serif font, i.e. <h2 class="font-family-sans" />. It'd become redundant once we switch to Public Sans, at which point we'd just want to return and remove it.

For reference, this is what it looks like with that change:

Before (current branch changes)	After

I can go ahead and make the change if it looks alright to you? I think it does match what's in the current Figma design, rendering at 1.25rem.

[anniehirshman-gsa]

I can go ahead and make the change if it looks alright to you? I think it does match what's in the current Figma design, rendering at 1.25rem.

LGTM thanks! 👍