LG-5185: Add SMS or Phone call full outage handling#5550
Merged
Conversation
aduth
added a commit
that referenced
this pull request
Oct 27, 2021
To make it easier to identify when mixed in See: #5550 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
aduth
added a commit
that referenced
this pull request
Oct 27, 2021
Because there's no creation See: #5550 (comment)
aduth
commented
Oct 27, 2021
solipet
added a commit
that referenced
this pull request
Oct 27, 2021
aduth
commented
Oct 27, 2021
solipet
added a commit
that referenced
this pull request
Nov 1, 2021
* LG-5184: Full page error on Acuant/LexisNexis outage * go back to the root path * vendor outage spec * refactoring to better align with work from #5550 * update locales * rubocop * removed unused locale keys * make normalize_yaml * vendor statuses are stored as symbols * separate messaging if existing user hits idv flow * refactor vendor_outage_concern * convert concern into a service object * final specs * removed unused code * remove extra check for unknown vendor Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * freeze vendor lists Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * don't need conditional check on `else` Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * YARD comment for outage_message * add the sms/voice configs * don't need to specify title if same as heading Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * remove fallback path on back partial Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * flatten the i18n keys * record that vendor outage came from idv in separate session key * inline VendorStatus usages Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * tighten up the guard clause Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
force-pushed
the
aduth-lg-5185-sms-phone-outage
branch
from
9322daa to
2c06ac2
Compare
Currently only ever called once
aduth
force-pushed
the
aduth-lg-5185-sms-phone-outage
branch
from
3b82647 to
4e2ef25
Compare
translation helper not available, locale message scope changed
Because dynamic context isn't natively understood by i18n-tasks
…step This is where phone confirmation redirect logic occurs by default
Also fixes case where "type" may be concatenated in multiple configuration scenario
consistency with existing "blocked" messaging
zachmargolis
approved these changes
Nov 16, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, appreciate the thorough screenshots! Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I expect that if I'm unable to complete steps within Login.gov due to an outage of its phone or SMS vendor (Amazon Pinpoint), I am prevented from starting those steps and shown a message which explains the situation.
Screenshots: