LG-5372 Minor content and styling update for IAL2 welcome and agreement steps.#5617
LG-5372 Minor content and styling update for IAL2 welcome and agreement steps.#5617amathews-fs merged 4 commits intomainfrom
Conversation
| <%= render 'shared/maintenance_window_alert' do %> | ||
| <h1><%= t('doc_auth.headings.welcome') %></h1> | ||
| <p class='mt-tiny margin-bottom-0'><%= t('doc_auth.info.welcome_html') %></p> | ||
| <p class='mt-tiny margin-bottom-0'><%= t('doc_auth.info.welcome_html', sp_name: decorated_session.sp_name) %></p> |
There was a problem hiding this comment.
Since sp_name might not always be available (e.g. local development, or after password recovery), should we keep around the old texts as a backup for those situations?
There was a problem hiding this comment.
Herm, I thought about this but was just thinking about local development...but you're right in the password recovery there wouldn't be an sp_name either.
I'll probably go with a default of "The agency" (translated) for simplicity in the rare cases where the public will encounter the page without an SP. Seem reasonable?
@anniehirshman-gsa thoughts?
There was a problem hiding this comment.
Yeah, from my perspective, that could work 👍
There was a problem hiding this comment.
I think the current text is "The agency you are trying to access...", so if that exists with translations already, we can use it as the back-up if no SP name is enabled?
amathews-fs
changed the title
| <h2><%= t('doc_auth.instructions.privacy') %></h2> | ||
| <p> | ||
| <h3><%= t('doc_auth.instructions.privacy') %></h3> | ||
| <p class="padding-bottom-2"> |
There was a problem hiding this comment.
Poking around some of the other flow designs, I wonder if we could update the "Cancel" partial to have margin-top-4 to achieve this same effect?
cc @anniehirshman-gsa do you think this makes sense? In other words, using 2rem top margin wherever we have "Cancel" link at the bottom of a page, where currently it is 1rem by default. We already do this with the "Start Over or Cancel" variation.
There was a problem hiding this comment.
Yeah, that definitely crossed my mind but I also didn't know what the impact would be of that across all the places it is used. It seemed like this was mostly because of the lack of a "start over" to go with it so I figured it could just be a one off. But if it's safe that's fine, I'll change it. That's just a much larger effect than the rest of this change set...
There was a problem hiding this comment.
I wonder if we could update the "Cancel" partial to have
margin-top-4to achieve this same effect?
Hm, one challenge is that the Start Over or Cancel partial composes the "Cancel" link, where we'd not want 2rem between "Start Over" and the Cancel link's border 🤔
There was a problem hiding this comment.
Yes, a consistent 2 rem space above the start over/cancel/back component would be great, but not sure how to best achieve that or if it's possible to make that change more widely without creating spacing issues elsewhere
There was a problem hiding this comment.
Yeah, I worry adding it globally here would create some oddities elsewhere that'll be a bit hard to nail down quickly.
There was a problem hiding this comment.
Given the limited scope of this ticket and change set, it would make more sense to me to split off the global change of styling for the start over/cancel/back component to another ticket.
| verify_identity: We’ll ask for your personal information. We’ll use, keep and | ||
| share some of your personal information to verify your identity against | ||
| public records. | ||
| verify_identity: We'll ask for your personal information to verify your identity |
There was a problem hiding this comment.
I wonder why make normalize_yaml isn't enforcing this as smart quotes like existed before ’.
I can follow-up to see if it's a bug with the normalization.
3 participants
LG-5372 - Updating the content and styling of the welcome step based on UX user research.
Figma here
Translations here