Skip to content

Remove document_capture_react_enabled configuration key#4154

Merged
aduth merged 1 commit intomasterfrom
aduth-remove-react-enabled-flag
Aug 31, 2020
Merged

Remove document_capture_react_enabled configuration key#4154
aduth merged 1 commit intomasterfrom
aduth-remove-react-enabled-flag

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Aug 31, 2020

Why: As a developer, I want less ambiguity and fewer combinations of configuration keys, so that I can feel confident in knowing how to toggle the React-based document capture.

This configuration key was originally added in #3994 to make it easier to test the fallback for the updated document capture flow. It is equally possible and more realistic to test this by disabling JavaScript in the browser (for example, using Chrome DevTools's Disable JavaScript setting).

Previously:

**Why**: As a developer, I want less ambiguity and fewer combinations of configuration keys, so that I can feel confident in knowing how to toggle the React-based document capture.
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit e9ed682 into master Aug 31, 2020
@aduth aduth deleted the aduth-remove-react-enabled-flag branch August 31, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants