Skip to content

Remove document_capture_react_enabled configuration key #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Aug 31, 2020
Merged

Remove document_capture_react_enabled configuration key #4154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions app/views/idv/doc_auth/document_capture.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,15 @@
<%= javascript_pack_tag 'image-preview' %>
</div>
<%= render 'idv/doc_auth/start_over_or_cancel' %>
<% unless Figaro.env.document_capture_react_enabled == 'false' %>
<%= nonced_javascript_tag do %>
<% asset_keys = [
'close-white-alt.svg',
'id-card.svg',
'spinner.gif',
'spinner@2x.gif'
] %>
window.LoginGov = window.LoginGov || {};
window.LoginGov.assets = <%= raw asset_keys.map { |key| [key, asset_path(key)] }.to_h.to_json %>;
<% end %>
<%= javascript_pack_tag 'document-capture' %>
<%= nonced_javascript_tag do %>
<% asset_keys = [
'close-white-alt.svg',
'id-card.svg',
'spinner.gif',
'spinner@2x.gif'
] %>
window.LoginGov = window.LoginGov || {};
window.LoginGov.assets = <%= raw asset_keys.map { |key| [key, asset_path(key)] }.to_h.to_json %>;
<% end %>
<%= javascript_pack_tag 'document-capture' %>
<% end %>
1 change: 0 additions & 1 deletion config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ disallow_ial2_recovery:
doc_capture_request_valid_for_minutes: '15'
doc_auth_extend_timeout_by_minutes: '40'
document_capture_step_enabled: 'false'
document_capture_react_enabled: 'true'
email_from: no-reply@login.gov
email_from_display_name: Login.gov
enable_load_testing_mode: 'false'
Expand Down
1 change: 0 additions & 1 deletion spec/features/idv/doc_auth/document_capture_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
let(:liveness_enabled) { 'false' }
let(:fake_analytics) { FakeAnalytics.new }
before do
allow(Figaro.env).to receive(:document_capture_react_enabled).and_return('false')
allow(Figaro.env).to receive(:document_capture_step_enabled).
and_return(document_capture_step_enabled)
allow(Figaro.env).to receive(:liveness_checking_enabled).
Expand Down