LG-3323 Desktop liveness upload page#4124
Conversation
…esktop docauth upload page. Added simple camera detection javascript.
| <%= render 'idv/doc_auth/start_over_or_cancel' %> | ||
| <%= javascript_pack_tag 'image-preview' %> | ||
|
|
||
| <% unless Figaro.env.document_capture_react_enabled == 'false' %> |
There was a problem hiding this comment.
With the unless and the false this is kind of a double negative... WDYT about flipping it?
<% if Figaro.env.document_capture_react_enabled == 'true' %>There was a problem hiding this comment.
Yeah, I noticed after I committed. I just stole that from something Doug put up recently. It's weird and I'll flip it.
There was a problem hiding this comment.
IIRC, originally it wasn't included in application.yml.default, as it was intended for local override. At that time, nil and 'true' were used interchangeably.
See: #3994
That being said, it might also be time to retire this configuration? I think @solipet expected it to be temporary for testing the fallback flow. We can still test this flow by disabling JavaScript (i.e. through Chrome DevTools).
There was a problem hiding this comment.
That is also an option. If it was only meant to be temporary I can remove the check. I have been using the browser based "disable javascript" to test anyway.
There was a problem hiding this comment.
I just removed the check because it wasn't really relevant anymore.
| @@ -0,0 +1,10 @@ | |||
| // app/packs/upload-step.js | |||
There was a problem hiding this comment.
does this line do anything?
3 participants
Changes to make sure the right states are showing up on the desktop docauth upload page. Added simple camera detection javascript.