Merged
Conversation
…and translations for verify information and verify phone screens (#12020)
changelog: Internal, Maintenance, Remove CodeClimate
changelog: Upcoming Features, Attempts API, Wiring up first event Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
changelog: Internal, Events, Drop column sp_return_logs.requested_at Step 3 of 3 Steps: 1. Add migration to drop the NOT NULL constraint and deploy 2. Add column to `ignored_columns`, remove all reads and writes and deploy 3. Drop column using `safety_assured` and deploy
* add service provider or logo to ready to verify email * Changelog: User-Facing Improvements, In-person proofing, display service provider logo or name in ready to verify email * use service provider instead of service provider session to display service provider logo * continue refactor to get logo from service provider, not service provider session * update tests * improve specs and method naming * reduce spec setup Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
* Changes to 'Update your address' screen * add changelog changelog: User-Facing Improvements, doc auth, make changes to update your address screen
* changelog: Upcoming Features, Attempts API, Add events
…lpers (#12016) changelog: Internal, Testing, Improve test reliability by adding page assertions in feature test helpers
* create doc_pii_state_id and doc_pii_passport * specs passing for state id * create specs for passport validation * rename doc_pii_passport and doc_pii_state_id * add pii_like_keypaths for forms * add changelog changelog: Internal, Doc Auth, Update doc auth PII validation for state id and passports * added pii_like_keypaths_state_id and pii_like_keypaths_passport * add passport_issued and expiration status * fix some specs part 1 * fix socure job error specs * fix analytics specs * added validation for issuing country code and nationality code
* changelog: Internal, Tech debt, Remove unused phone confirmation database fields * replace missing unrelated spec. add confirmed_at to ignored columns * reverses changes affecting in-use table phone_configurations.confirmed_at
mitchellhenke
approved these changes
Apr 1, 2025
jmdembe
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features